Revival by a contributor?

[Stapleton]

Hello,

I would like to revive this project and fix the bugs that it currently has that are preventing the software from working as intended.
Unfortunately, I am unable to recreate your dev environment from the context clues of all your project config files.

If you could be kind enough as to give me a list of the tools you used and a quick rundown on how you configured them together.
I would be more than likely to take what you have already created, and maintain it back into functioning order.

As well as make some changes to allow the program to adapt easily to save file changes in the future.
Assuming I find any areas of the application that would need this kind of treatment.
That treatment would be less so invasive logic changes and more so slight restructuring to make parts of the application data-driven from either the save file itself or a schema described through a json file or similar.

Fallbacks for discovering save files and other file locations would be another thing I would like to add among others.

I look forward to a reply! Thanks.

[jaszhix]

Hi, sadly I've had no time to update this, but you're more than welcome to help. What particular errors are you running into? There shouldn't be anything special about reproducing the dev environment, but you will likely need to be using an older node runtime initially. The project is pretty behind on dependencies.

[Stapleton]

No worries! I am also fairly busy during the week however I am looking for something to do on the weekends these days.
I am running into errors during the yarn install process. Specifically node-gyp and the python build scripts for some of the packages.
Seems like the build process checks for Python2 first then Python3, with a failing due to SyntaxError.
My guess is the build scripts in some of the dependencies are clashing with the Python3 changes and the absence of Python2 on my system.
I am currently giving Python2 a try with it and will see how it goes.
In the event this doesn't work out in my favor, can you recall which versions of Python and Node you used?

Update:
Python2 was the fix to the electron build issue. I am now facing a very non-descript error from building node-sass.
I might be missing something but theres success in finding the proper msvc build tools but all of a sudden the process exits.
Could you possibly shed some light on this? https://pastebin.com/9KzrW28u

[jaszhix]

It looks like you're trying to use node 22. I would install nvm or nvm-windows and use it to install node 12 or node 14 temporarily to establish the local env. If you're using the non-windows nvm, you can set an .nvmrc that does this automatically (something I should have done for this project). The package.json gives an idea of which era of node versions is likely to work best. I think I was working with Node 14 when I last updated NMC.

"devEngines": {
    "node": ">=10.x",
    "npm": ">=6.x",
    "yarn": ">=1.16.x"
  }

Edit:

Looking at your log again, I think you're also missing windows-build-tools:

npm install -g windows-build-tools

[ToustCZ]

No worries! I am also fairly busy during the week however I am looking for something to do on the weekends these days. I am running into errors during the yarn install process. Specifically node-gyp and the python build scripts for some of the packages. Seems like the build process checks for Python2 first then Python3, with a failing due to SyntaxError. My guess is the build scripts in some of the dependencies are clashing with the Python3 changes and the absence of Python2 on my system. I am currently giving Python2 a try with it and will see how it goes. In the event this doesn't work out in my favor, can you recall which versions of Python and Node you used?

Update: Python2 was the fix to the electron build issue. I am now facing a very non-descript error from building node-sass. I might be missing something but theres success in finding the proper msvc build tools but all of a sudden the process exits. Could you possibly shed some light on this? https://pastebin.com/9KzrW28u

Holy moly, I am so excited to see this fixed again. Please revive it, people need it.

[jaszhix]

After playing with the dev environment for a bit, I can conclude that you do indeed need Node 14. I am able to run it locally, and after updating NMS and letting it write a new save file, I can see NMC is not able to parse it anymore. I can attempt to modernize the dependencies and tooling, but not sure how far I would get updating the save file parser code, as it is something the community has actually helped modernize, and navigating opaque binary formats is not something I am specially equipped to deal with.

NMS used to have plain text JSON save files, which is probably the only reason NMC ever existed in the first place.

[Faust3D]

NMS save editor project figured that one out, you might want to check there.

https://github.com/goatfungus/NMSSaveEditor

[jaszhix]

Unfortunately that would require decompiling their jar file, and I intend to respect other maintainers' license terms. If anyone wants to help out in this regard though, that's whats needed to revive NMC.

[Faust3D]

Maybe you can just ask goatfungus for help on this.

[jaszhix]

This project is not abandoned, but it is also not being actively developed right now. The single blocker is an updated implementation of the NMS save file parser. Without that, nothing else can move forward.

Everything else in the project, from the UI to the community features, is functional and ready to evolve. But until the parser issue is solved, progress is impossible.

For contributors:

• If you can reverse engineer and implement the parser, you can revive this project. That is the one piece that matters.

• If you cannot, that is fine, but please understand that comments, requests, or emoji reactions do not move the project forward. They create noise, not progress.

The repo is licensed under GPLv3. That means anyone is free to fork it, experiment, and share improvements. The door is open to anyone willing to do the work.

[Faust3D]

I saw that goatfungus replied on the other thread. Hopefully someone on the team can work with him to figure these JSON formatting issue out out. I am just a simple user without in depth tech knowledge that wants to see this project revived. Thanks for all the work you have done on this so far.

[Reiss-Cashmore]

My PR is open which implements a new codec and a few fixes to save file formatting. No more JSON encoding issues!

Still needs someone to go through and make the updates to the save file types now