fix(release): include maintenance notes without triggering releases - #125
Merged
Conversation
Show documentation, build, and CI entries in eligible release notes and always refresh pending release branches. Use a pinned read-only eligibility planner isolated from App credentials, bind it to main, and separate release creation from PR creation. Validation: pinned policy and workflow tests plus live read-only eligibility planning. The installed pre-commit hook runs the full scripts/ci-preflight.sh on the exact staged tree before recording this commit. Signed-off-by: jatmn <the@jat.mn>
jatmn
marked this pull request as ready for review
September 5, 2026 21:18
There was a problem hiding this comment.
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. If the eligibility planner or workflow gating is wrong, it can create or refresh release branches and notes unexpectedly, and the protected action can still create tags or releases for pending merged releases. Reverting stops future runs but does not undo release PRs, generated notes, tags, or releases already created; human review of release PRs limits the impact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release Please skipped refreshing #116 after build-only merges because its generated notes were unchanged. The configuration also hid documentation, build, and CI entries.
Enable native
always-updateand show those three sections. A separate read-only pinned Manifest planner checks eligibility with those sections hidden, so ordinary docs/build/ci changes appear in an eligible release's notes without opening releases themselves. Breaking changes and explicit version overrides retain their existing behavior.The planner runs without protected credentials. The protected job verifies its source SHA, then runs tag/draft creation and eligible PR creation as separate native action phases. Existing release and missing-draft recovery remain independent of ordinary release eligibility.
Related: #116. That release branch has already been refreshed with main and the omitted entries. Merge this policy PR first, let the worker regenerate and recheck #116, then merge #116. Permanent policy changes stay outside the bot PR's four-file allowlist.
Contribution checklist
Validation
bash scripts/ci-preflight.shon the committed snapshot: source/release/recovery/workflow harnesses, clippy, 996 Rust tests, build, docs, CLI smokes, deny and audit passed. Mutation testing correctly skips this non-Rust diff.bash scripts/install-git-hooks.sh; pre-commit passed and pre-push repeats required validation.releasable=true.Reviewed commit:
962a406d9e83e60b1206544e01e4ade2a37dec2e. Protected workflow mutations are not exercised locally; the policy becomes active after merge.Maintainer checklist
Summary by Sourcery
Refresh eligible release branches and include maintenance notes while keeping ordinary documentation, build, and CI changes from opening releases on their own.
New Features:
Bug Fixes:
Enhancements:
Documentation:
Tests: