Skip to content

Fixing test #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndreasIgel merged 3 commits into from
Mar 11, 2026
Merged

Fixing test #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
10368b0
Fixing test
AndreasIgel Mar 11, 2026
ad7ea24
Disabling test because of missing feature
AndreasIgel Mar 11, 2026
6616a8c
Removing example builder for conflictExample because this is not stab…
AndreasIgel Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion example/src/main/java/org/javahelpers/simple/builders/example/FieldConflictExample.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
*
* @see org.javahelpers.simple.builders.core.annotations.IgnoreInBuilder
*/
@SimpleBuilder
// @SimpleBuilder - needs to be reactivated after having #132 checked
public class FieldConflictExample {
private String firstName;
private java.util.Optional<String> lastName;
Expand Down
239 changes: 0 additions & 239 deletions ...rces/annotations/org/javahelpers/simple/builders/example/FieldConflictExampleBuilder.java
View file
Open in desktop

This file was deleted.

4 changes: 3 additions & 1 deletion processor/src/test/java/org/javahelpers/simple/builders/processor/BuilderProcessorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import javax.tools.JavaFileObject;
import org.javahelpers.simple.builders.processor.testing.ProcessorAsserts;
import org.javahelpers.simple.builders.processor.testing.ProcessorTestUtils;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

/** Tests for the {@link BuilderProcessor} class. */
Expand Down Expand Up @@ -2681,6 +2682,7 @@ public class InnerClass {
}

@Test
@Disabled("Missing feature: #131")
void shouldHandleOverloadedSettersForSameFieldWithoutConflicts() {
// Given
String packageName = "test";
Expand All @@ -2695,7 +2697,7 @@ void shouldHandleOverloadedSettersForSameFieldWithoutConflicts() {
private java.util.List<String> names;

public java.util.List<String> getNames() { return names; }
public void setNames(java.util.List<String> names) { this.names = names; }
public void setNames(String[] names) { this.names = names; }
public void setNames(String... names) { this.names = java.util.List.of(names); }
""");

Expand Down
Loading