Skip to content

Improving testfailure-messages #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndreasIgel merged 3 commits into from
Mar 11, 2026
Merged

Improving testfailure-messages #134

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2e3e35
Improving testfailure-messages
AndreasIgel Mar 11, 2026
d4661e2
improving code quality
AndreasIgel Mar 11, 2026
0d90304
Further improvements in code quality of Assert-Utils
AndreasIgel Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 17 additions & 14 deletions ...sor/src/test/java/org/javahelpers/simple/builders/processor/testing/ProcessorAsserts.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
import java.util.ArrayList;
import java.util.List;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.function.Executable;

/**
* Assertion helpers for processor tests. Centralizes common positive and negative checks and
Expand Down Expand Up @@ -74,23 +73,19 @@ public static NotContainsAssertRecord notContains(String search) {

/** Assert that generated code matches all provided checks (positive or negative). */
public static void assertingResult(String generatedCode, AssertRecord... checks) {
List<Executable> executables = new ArrayList<>();
String normalizedGenerated = normalizeWhitespace(generatedCode);
List<String> failures = new ArrayList<>();

for (AssertRecord check : checks) {
String normalizedSearch = normalizeWhitespace(check.search());
if (check instanceof ContainsAssertRecord) {
executables.add(
() ->
Assertions.assertTrue(
normalizedGenerated.contains(normalizedSearch), check.message()));
} else if (check instanceof NotContainsAssertRecord) {
executables.add(
() ->
Assertions.assertFalse(
normalizedGenerated.contains(normalizedSearch), check.message()));
if (isAssertNotFullfilled(check, normalizedGenerated)) {
failures.add(check.message());
}
}
Assertions.assertAll(executables.toArray(new Executable[0]));

if (!failures.isEmpty()) {
String combinedMessage = "\n" + String.join("\n", failures);
Assertions.fail(combinedMessage);
}
}

/** Convenience overload: accept plain strings and convert to NotContainsAssertRecord. */
Expand Down Expand Up @@ -133,4 +128,12 @@ public static void assertHadNoteContaining(Compilation compilation, String... no
public static void assertNormalizedEquals(String expected, String actual, String message) {
assertEquals(normalizeWhitespace(expected), normalizeWhitespace(actual), message);
}

private static boolean isAssertNotFullfilled(AssertRecord check, String normalizedGenerated) {
String normalizedSearch = normalizeWhitespace(check.search());
return (check instanceof ContainsAssertRecord
&& !normalizedGenerated.contains(normalizedSearch))
|| (check instanceof NotContainsAssertRecord
&& normalizedGenerated.contains(normalizedSearch));
}
}
Loading