Repository navigation
Tighten coverage gates (require CI to pass; measure mapper logic) - #184
Merged
AndreasIgel merged 2 commits intoJul 20, 2026
Merged
AndreasIgel merged 2 commits into
AndreasIgel merged 2 commits into
Conversation
- codecov.yml: require_ci_to_pass: true so a green coverage status can't mask a failed CI build/tests. - Drop the broad **/*Mapper* wildcard from sonar.coverage.exclusions and the JaCoCo excludes so real mapper logic (RoasterMapper ~69%, JavaLangMapper ~93%) is measured; keep excluding DTO model, exception packages and generated sources. Sonar and JaCoCo kept in sync. Processor line coverage remains ~93% (well above the 80% project target). Refs java-helpers#162 Co-Authored-By: Andreas Igel <andreas.igel@computacenter.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
2 of 3 tasks
devin-ai-integration
Bot
deleted the
feature/162-tighten-coverage-gates
branch
August 16, 2026 21:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the coverage signal honest and enforced.
Fixes #162
codecov.yml:require_ci_to_pass: false→true, so a passing coverage status can't be reported when the CI build/tests failed.**/*Mapper*wildcard (it hid real code-generation logic — measuredRoasterMapper~69%,JavaLangMapper~93%). Kept genuine boilerplate excluded (DTOmodelpackage, exception packages via**/exceptions/**, generated sources).sonar.coverage.exclusions(rootpom.xml) and the JaCoCoexcludes(processor/pom.xml) are kept in sync.The 80% project target is retained: measured processor coverage stays ~93% with the mappers now included, so there's ample headroom without loosening.
Validation
mvn -Pmetrics clean verifypasses; processor overall instruction coverage 93.2% withRoasterMapper/JavaLangMappernow present in the JaCoCo report andRoasterMapperExceptionstill excluded.codecov.ymlis valid YAML.Note (out of scope, flagged for follow-up): under local Maven 3.6.3 the core module's tests report "Tests run: 0" (core doesn't pin
maven-surefire-pluginlikeprocessordoes), so core shows 0% locally. This looks like an old default-surefire/JUnit5 discovery issue; happy to open a separate issue/PR to pin surefire incore.Existing red checks (
build,dependency-review) are the fork's missingSONAR_TOKEN/CODECOV_TOKENand disabled Dependency graph — unrelated.Maintainer TODOs
require_ci_to_pass: true, Codecov only reports a passing status once CI actually passes — if you gate merges on the Codecov status, make sure it is added to branch protection.