Repository navigation
Add opt-in strict mode for Jackson module generation failures - #195
Closed
AndreasIgel wants to merge 1 commit into
Closed
AndreasIgel wants to merge 1 commit into
AndreasIgel wants to merge 1 commit into
Conversation
Promote Jackson module generation failures from warnings to compiler errors when the shared strict option (-Asimplebuilder.strict=true) is set. The default is unchanged: failures remain warnings and the build succeeds. Fixes java-helpers#173 Co-Authored-By: Andreas Igel <andreas.igel@computacenter.com>
Collaborator
Author
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the opt-in strict/fail-fast mode to Jackson module generation failures. When
-Asimplebuilder.strict=trueis set, a failure to generate a JacksonSimpleModuleis reported as a compiler error that fails the build instead of a warning.STRICTcompiler option /simplebuilder.strictargument.BuilderProcessor'sprocessingOver()Jackson loop reports an error instead of a warning when strict is enabled.README.md.The default is unchanged: Jackson module generation failures remain warnings and the build still succeeds.
Validation
mvn clean verify— green (285 processor tests). NewJacksonModuleStrictModeTestcovers both default (warning, compilation succeeds) and strict (error, compilation fails) behavior.Fixes #173