Repository navigation
Isolate generator runtime failures so one class cannot abort the round - #197
Merged
AndreasIgel merged 2 commits intoJul 19, 2026
Merged
AndreasIgel merged 2 commits into
AndreasIgel merged 2 commits into
Conversation
RoasterMapper reports mapping failures via RoasterMapperException, a RuntimeException. During class rendering this escaped the per-element and Jackson resilience loops in BuilderProcessor (which catch only BuilderException), aborting the entire processing round. Convert RuntimeExceptions thrown while building the class source into the checked BuilderException in RoasterCodeGenerator.generateClass so callers isolate the failure to the offending class and keep generating the rest. Fixes java-helpers#175 Co-Authored-By: Andreas Igel <andreas.igel@computacenter.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens generator error handling so a single failing class no longer aborts the whole annotation-processing round.
RoasterMapperreports mapping failures viaRoasterMapperException, aRuntimeException. During class rendering this escaped the per-element and Jackson resilience loops inBuilderProcessor(which catch only the checkedBuilderException), aborting generation for every remaining element.RoasterCodeGenerator.generateClass(...)now convertsRuntimeExceptions thrown while building the class source into aBuilderException, so the existing resilience loops isolate the failure to the offending class (a warning by default) and keep generating the rest.Other error-handling paths in
GeneratorRegistry,RoasterCodeGenerator, andRoasterMapperwere reviewed; findings are documented in the linked issue.Validation
mvn clean verify— green (284 processor tests). NewRoasterCodeGeneratorResilienceTestasserts a renderingRoasterMapperExceptionis surfaced as aBuilderException.Fixes #175