Skip to content

Remove dependency-submission workflow (no value for PRs) - #217

Merged
AndreasIgel merged 1 commit into
java-helpers:mainfrom
AndreasIgel:feature/remove-dependency-submission
Jul 26, 2026
Merged

AndreasIgel merged 1 commit into
java-helpers:mainfrom
AndreasIgel:feature/remove-dependency-submission

Conversation

@AndreasIgel

Copy link
Copy Markdown
Collaborator

Summary

Removes the dependency-submission.yml workflow (added in #213). It doesn't help the problem it was meant to address and adds confusion.

  • It submits a Maven dependency snapshot only on pushes to main. It cannot produce a snapshot for a fork PR's head SHA (that would require building untrusted fork code with a write token), so it does nothing for the "No snapshots were found for the head SHA" warning on PRs.
  • The actual fix for that warning is configuration only — comment-summary-in-pr: on-failure in dependency-review.yml (Stop dependency-review from commenting the benign fork-PR snapshot warning #216).
  • GitHub's automatic dependency graph already parses pom.xml, so keeping this extra workflow around mostly adds noise/maintenance without a clear benefit for this repo.

Net effect: one fewer workflow to reason about; dependency-review still runs and still gates on vulnerabilities/licenses.

Related

…uses (java-helpers#212)

Co-Authored-By: Andreas Igel <andreas.igel@computacenter.com>
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Deprecation Warning: The deny-licenses option is deprecated for possible removal in the next major release. For more information, see issue 997.

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 85cd8e8.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

  • .github/workflows/dependency-submission.yml

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Jul 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@AndreasIgel
AndreasIgel merged commit 6104f48 into java-helpers:main Jul 26, 2026
6 checks passed
@AndreasIgel
AndreasIgel deleted the feature/remove-dependency-submission branch July 26, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant