Repository navigation
Migrate dependency-review to allow-licenses (deny-licenses deprecated) - #218
Merged
AndreasIgel merged 1 commit intoJul 26, 2026
Merged
Conversation
…nses (java-helpers#160) Co-Authored-By: Andreas Igel <andreas.igel@computacenter.com>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Migrates
dependency-review.ymloff the deprecateddeny-licensesoption (the action now warns it may be removed in the next major release — actions/dependency-review-action#938) to the supportedallow-licensesallow-list. Reopens/addresses #160.Semantic change (please note)
allow-licensesanddeny-licensesare mutually exclusive and behave oppositely:deny-licenses(before): fail-open — only detected copyleft (GPL/LGPL/AGPL) fails; a dependency with an unrecognized/OTHERlicense is reported but passes.allow-licenses(after): fail-closed — any introduced dependency whose license is not on the list fails, including unrecognized/OTHERones.Fail-closed is the stronger posture and matches the deprecation's recommended direction, but it can surface false failures when ClearlyDefined can't identify a license. If that happens, either add the specific SPDX id or exempt the package via
allow-dependencies-licenses.How the list was derived
Enumerated the full dependency tree across all modules (core, processor, example, example-custom-generator) via
license-maven-plugin:aggregate-third-party-report(35 deps, all with declared licenses). Distinct licenses found → SPDX:Apache-2.0MITEPL-1.0EPL-2.0BSD-3-ClauseNo GPL/LGPL/AGPL present. The allow-list adds the standard permissive set for a Java/MIT project (BSD-2-Clause, CDDL-1.0/1.1, ISC, Unlicense, CC0-1.0) as headroom for common transitive deps.
Note
Touches the same block as #216 (which flips
comment-summary-in-prtoon-failure), so a trivial conflict is expected on whichever merges second — easily resolved (they change adjacent, unrelated lines).Related