feat(resolver): require no-arg constructor in referenced builder contract - #311
Merged
AndreasIgel merged 1 commit intoOct 1, 2026
Merged
Conversation
…ract The nested-builder consumer emits new FooBuilder() when the field is unset, but the contract check only verified ctor(T) + build(). A hand-written builder without a no-arg constructor passed the contract and produced uncompilable generated code. The contract now additionally requires a no-arg constructor. Referenced builders lacking it no longer qualify and their fields degrade to plain setters (breaking change, resolves java-helpers#308). Co-Authored-By: Andreas Igel <andreas.igel@computacenter.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues: closes #308 · sub-task of #301
Summary
Extends the referenced-builder contract in
BuilderScopeResolver.resolveByBuilderContractwith a no-arg-constructor requirement:ctor(T)+B()+build().Why
The nested-builder consumer emits
new FooBuilder()when the field is unset, but the contract only verifiedctor(T)+build()— a hand-written builder without a no-arg ctor passed and produced uncompilable generated code. The check reuses the existingJavaLangAnalyser.hasEmptyConstructorhelper and matches the style of the other contract members (presence-based).Breaking change
Referenced builders that satisfied the previous contract but lack
B()stop qualifying; their fields degrade to plain setters (correct output, but observable).Tests
resolverUsageScope_RejectsBuilderWithoutNoArgConstructorcovers the rejection pathB()— 469 processor tests greenNotes
docs/CONFIGURATION.md(builderUsagePackages,builderUsageSuffix).