Skip to content

Conversation

@andrey-patin-1979
Copy link

Added functionality for providing exotic port's names on Linux and MacOS as was asked in (#179 (comment)) and tests for this new functionality as was asked in (#179 (comment))

@tresf
Copy link

tresf commented Jan 10, 2025

I request we find a better word than EXOTIC that's more suitable. These port names are not exotic, they're just proprietary, or in many cases, just undocumented, or more simply an additional pattern to match.

@tresf
Copy link

tresf commented Jan 10, 2025

Thanks for this effort. I believe some refactoring is required prior to merger. Thoughts welcome.

@andrey-patin-1979
Copy link
Author

I request we find a better word than EXOTIC that's more suitable. These port names are not exotic, they're just proprietary, or in many cases, just undocumented, or more simply an additional pattern to match.

So how do you want me to call them?

@andrey-patin-1979
Copy link
Author

@tresf, regarding error "/home/runner/work/jssc/jssc/src/test/java/jssc/SerialPortListTest.java:[27,63] method references are not supported in -source 6"
Do you really need to keep compatibility with Java 6, in that case I will look for mock-mechanism which will work on Java 6, current one works on Java 8 and higher?

@tresf
Copy link

tresf commented Jan 14, 2025

Closing as non-planned, this is already covered by getPortNames(...). Thanks for the contribution, even if it wasn't accepted. We appreciate those that take the time to contribute back to this library!

@tresf tresf closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants