Skip to content

feat(#12): Cache changes on webserver#40

Merged
javatarz merged 3 commits into
javatarz:masterfrom
sathia27:pr_github_cache
Oct 19, 2019
Merged

feat(#12): Cache changes on webserver#40
javatarz merged 3 commits into
javatarz:masterfrom
sathia27:pr_github_cache

Conversation

@sathia27

Copy link
Copy Markdown

Add details of your PR here..

Checklist

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same feature you're adding?
  • Have you run tests (pipenv run pytest) before sending this PR?
  • Have you run linting (./lint.sh) before sending this PR?

@javatarz javatarz self-requested a review October 19, 2019 05:29
@javatarz javatarz self-assigned this Oct 19, 2019
@javatarz javatarz added the enhancement New feature or request label Oct 19, 2019
@javatarz

Copy link
Copy Markdown
Owner

Hey @sathia27, thank you for your contribution! I noticed you're importing redis but it isn't mentioned in the Pipfile. The Pipfile is what ensures all python dependencies are installed consistently on all machines. If you run pipenv install redis, it'll update the Pipfile and Pipfile.lock.

This is also a good opportunity for you to send another PR to update the contribution.md file about this so future contributors know they should be doing this :)
I'll create an issue for this.

Comment thread ghcl/cache.py
Comment thread ghcl/cache.py Outdated
@sathia27

Copy link
Copy Markdown
Author

@javatarz
Thank you for your quick response

Made few other changes as you mentioned.

  1. pipfile changes related to importing redis - Done
  2. removed constant for cache duration. Use args instead of constant - Done
  3. changes to contribution.md, regarding importing new package.

@javatarz javatarz merged commit c3b7bee into javatarz:master Oct 19, 2019
javatarz added a commit that referenced this pull request Oct 19, 2019
This reverts commit c3b7bee, reversing
changes made to 9d99eab.
javatarz added a commit that referenced this pull request Oct 19, 2019
Revert "Merge pull request #40 from sathia27/pr_github_cache"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants