Repository navigation
machweb: serve_on_quiet, for a caller that announces its own bind - #674
Conversation
serve_on prints "machweb on http://host:port" to stdout. The agent-first CLI contract puts that line on stderr -- it is context, not data -- and a service whose stdout is JSON hands a parser a log line on startup. Rather than change what every existing caller does, this adds a silent variant. Same bind, same exit-on-failure, no announcement: the caller decides where its own startup line goes. machin-bkn uses it to meet cli-daemon-spec §1, which requires the line on stderr and nothing on stdout. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XJdASnjD4R5h6xX2fzfMfk
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change adds ChangesMachweb server startup
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The quiet entry point leaves request serving and bind-failure behavior intact while avoiding a startup banner. No merge-blocking risk is evident. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
serve_onprintsmachweb on http://host:portto stdout. The agent-firstCLI contract puts that line on stderr — it is context, not data — and a
service whose stdout is JSON hands a parser a log line on startup.
This adds a silent variant rather than changing what existing callers do: same
bind, same exit-on-bind-failure, no announcement. The caller decides where its
own startup line goes.
machin-bknuses it to meet cli-daemon-spec §1, which requires theconfirmation on stderr and nothing on stdout. Verified there: stdout is
empty, stderr carries
[serve] listening on http://127.0.0.1:PORT, and the191-assertion contract suite still passes.
Additive — no existing behaviour changes.
🤖 Generated with Claude Code
https://claude.ai/code/session_01XJdASnjD4R5h6xX2fzfMfk
Summary by CodeRabbit