Hmc dev#7
Open
eelcovv wants to merge 12 commits into
Open
Conversation
added 9 commits
February 5, 2016 15:48
…nged OCC routine on line 91 to small letters
Owner
|
Hi @eelcovv. The pull request looks great. Thanks for testing cadmium on Windows. I'll be glad to accept this pull request, but it will be better to squash all the commits into a single commit. That way if we find any regressions in future, they will be easy to locate using git-bisect. (If you need any help with squashing, here's some git help https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History#Squashing-Commits) |
added 3 commits
July 5, 2017 06:09
…need 0.17 for free cad. This is a no-go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Jay3sh
Thanks for this excellent solid modeller tool. It looks very promissing to my project
However, I have installed your module under windows and had to do quite some fixed in order to get the examples running. It seems that some naming in the OCC are different.
Perhaps you could review my changes and see if they also apply under the linux version as well. Otherwise perhaps you could add a operating system check to switch between windows and linux. Everything I have changed in solid.py relates to different namings.
The only example I could not get going number 11 which now gives the error "Wrong number or type of arguments for overloaded function 'gp_XYZ_Coord'." Perhaps you can see what goes wrong.
The other example is the test-example which is using fontforge. I could never get this installed. So I have added a try/except in the source because otherwise you can not load the module in the first place. Now only the font related examples do not work if you don't have fontforge
Anyway, all other examples are working like a charme. I think this is a really handy module
Regards
Eelco