Conversation
…sing checkpoints for New Learner Dashboard (oppia#24724) * made changes * made changes * Progress pass issue * Added backend files * fixed lint and mypy check * Fixed failing tests * fixed failing backend checks * fixed backend tests * fixed backend tests * fixed backend tests * fixed backend tests * fixed backend tests * add tests for backend coverage * add tests for backend coverage * add tests for backend coverage * Fixed failing coverage * Add test for missing progress data coverage * Implemented progress updation similar to classroom lessons * removed unrelated files * removed unrelated files * added test * added test * removed progress field * fixed type checks and lint checks * added frontend tests * Apply suggestion from @brianrodri Co-authored-by: Brian Rodriguez <brian@brianrodri.com> * Apply suggestion from @brianrodri Co-authored-by: Brian Rodriguez <brian@brianrodri.com> * Apply suggestion from @brianrodri Co-authored-by: Brian Rodriguez <brian@brianrodri.com> * Made requested changes * Reordered import statements at top and used swap_to_always_return * fixed ci checks * Fixed progress for collections * fixed frontend coverage * Made some suggested changes --------- Co-authored-by: Brian Rodriguez <brian@brianrodri.com>
* Fix part of oppia#23496: Enforce strict type checks in group 22 * removed group 22 files from run_typescript_checks.py * fix unknown type and empty initialization to correct type * Fix eslint error: replace Type<any> with Type<unknown>
… StoryModel with id story_id not found" (oppia#24841) Fix generate dummy chapters: use story_id
…icate modal (oppia#25244) Fix oppia#20274: Disallow future dates in certificate modal date picker
* Updated issue template for flakes * fixed some typos * Updated the template to redirect user to wiki for detailed filing info
…ent in workflow (oppia#25161) * Fix PTAL workflow: ignore quoted lines and prevent self-assignment * Fix lint: ensure single newline at EOF * Trigger CLA recheck
…-assignment in workflow" (oppia#25410) Revert "Fix oppia#22289: Ignore quoted PTAL comments and prevent self-assignment i…" This reverts commit edade98.
…sts (oppia#25223) Fix oppia#21285: Remove flaky stderr assertion in test_start_subprocess_for_result
…5220) * Add check to guard against unused i18n keys * Add one more missed case * Address review comment. * Drop one extra key
* completed the audit and migration job * fixed linting error * Refactor blog author migration jobs to remove DATASTORE_UPDATES_ALLOWED flag and streamline model persistence * Refactor blog author details migration jobs to improve structure and readability * Remove unnecessary blank line in blog author details migration jobs file * Add unit tests for migrating blog author details of deleted users * removed audit_topics_with_hanging_stories_job
oppia#25086) * Fix translation count validation error by recounting translations * Fix oppia#21878: Prevent duplicate translation suggestions and acceptance validations * Fix oppia#21878: Prevent duplicate translation suggestions and acceptance validations * Fix email_manager_test duplicate suggestion conflicts * Revert unwanted Snyk settings and fix accept_suggestion version mismatch * Fix suggestion_services_test duplicate content_id conflicts * Add ExplorationOpportunitySummaryAuditModel to storage models * Implement and register ValidateExplorationOpportunityCountsJob beam job * Add audit tracking hooks adapted to recount logic in opportunity_services * Fix lint errors in translation audit job and tests * Remove unused exp_models import from translation audit job * Fix isort import formatting in translation audit job * Add translation_audit_jobs_test to backend test shards * Fix CI: add translation_audit_jobs to test shards and linter fixture * Add tests for uncovered lines in translation_audit_jobs.py
…st reports (oppia#25079) Correct average test case time calculation in backend test reports Co-authored-by: Hardik Goyal <135348086+HardikGoyal2003@users.noreply.github.com>
Fix RTE image widget dismissal on Esc
…sks (oppia#25217) * implemented the infra, left with testing and unit tests * removed the temp file * corrected the variable name * Fixing CI - 1 * fixing mypy and lint * Fixing CI * fixing CI * adding coverage * fixing CI * added max 3 retries limit * added the TODO comment * added do link * fixed lint
* Updates spec files to support changes made in 098eeab * for-testing: updates forontend CI to allow manual trigger * for-testing: removed concurrency group in frontend tests to do stress test. * Revert "for-testing: removed concurrency group in frontend tests to do stress test." This reverts commit 7c6e15e. * Revert "for-testing: updates forontend CI to allow manual trigger" This reverts commit 6c6c9b8.
…ppia#25485) Enable video recording in mobile acceptance tests
…ppia#25480) Revert "Fix oppia#23683: Align learning progress checkpoint numbers (oppia#24338)" This reverts commit 8ddc60b.
…ign (oppia#25274) * Created UI , Logic , Unit tests , feature flag for campaign banner * Lint checks * Lint check and test fix for financial-campaign * Changes is made to show banner on only about,blog,contact,learner dashboard, partnership,splashpage ,tech page and volunteer page. Created campaign banner module * Fix TypeScript check * Fix lint check in .html * removed banner from learner dashboard * Added a flag for test mode * Added analytic event for tracking click on campaign donate button * Added analytic function for trcking banner visiblity and changed image from png to webp * Added analytics for registerCampaignBannerVisibility renamed feature flags * Deleting .png file --------- Co-authored-by: mosin74 <mosin74@gmail.com>
…dict (oppia#25336) Rename controller entity payload keys to *_dict
…FAILED(CI Failure) (oppia#25600) * Fixed InsertScriptService frontend ci failure * fixed merge conflicts * added changes in more test
…eer acceptance test and remove legacy test (oppia#24909) * Migrate explorationTranslationTab E2E test to Puppeteer acceptance test * Update acceptance test screenshots * Fix accessible name extraction for upload voiceover button * Fix voiceover upload accessibility and stabilize accent selection in acceptance tests * Fix flaky mobile navbar dropdown closing in acceptance tests * Removing waitForNetworkIdle
…nce test (oppia#25536) * fixed the flake in curriculum-admin/create-edit-and-delete-a-classroom * fix 1 * fix 2 * Fix flaky mobile test in curriculum admin * fixing CI
Co-authored-by: Kartik Suryavanshi <158498247+KartikSuryavanshi@users.noreply.github.com> Co-authored-by: Nikhil <nikhil.agarwal.2019@gmail.com>
…ppia#25526) * Update guppy-dev dependency to include CapsLock fix (oppia#18626) * Update guppy-dev hash and Guppy typings for oppia#18626 * Trigger CI rerun * Update Guppy typings source path comment
…oppia#24837) * Preserve normal blog pagination state on page refresh * Preserve search blog pagination state on page refresh * Minor Fix * Minor Fix * Minor Fix * Fixed all the ci failure * Fixed all coverage checks * Addressed review comments and fixed some issues on the search blog page * Minor Fix * Fixed CI Checks * Fixed tag filter issue * Fixed Failed CI checks * Fixed ci fail * Fixed ci fail * Fix CI fail * Revert "Fix CI fail" This reverts commit 5c3e5ae. --------- Co-authored-by: Hardik Goyal <135348086+HardikGoyal2003@users.noreply.github.com> Co-authored-by: Kartik Suryavanshi <158498247+KartikSuryavanshi@users.noreply.github.com>
…k state (oppia#24835) * Fix learner stuck navigation bug by restoring original state * Fixing failing tests * Fixing Coverage Issues * Fixing Lint Issues * Clean up comments in conversation-flow.service.ts Removed redundant comments regarding stuck state redirection.
…iting for script (oppia#24861) fix(interactions): lazy load pencil code library and correct license header Co-authored-by: Ninja-lgtm <kamityush@gmai.com>
…pia#25089) * Fix: Display tags in Preview Summary Card - Add ExplorationTagsService to preview modal - Pass tags to exploration-summary-tile component - Display tags with styled badges - Update unit tests * Fix typo in service names in PreviewSummaryTileModalController tests * Fix exploration tags initialization in PreviewSummaryTileModalController tests
…tems allowed (oppia#25343) * Fix drag and drop interaction with keyboard when multiple items allowed Drag and Drop interaction accessible by keyboard when the option Allow_multiple_sort_items_in_the_same_position is ticked. A new method was implemented to handle keys in that case, using the existing methods moveItemInArray and transferItemInArray. * Fix drag and drop interaction with keyboard when multiple items allowed Drag and Drop interaction accessible by keyboard when the option Allow_multiple_sort_items_in_the_same_position is ticked. A new method was implemented to handle keys in that case, using the existing methods moveItemInArray and transferItemInArray. * Fix unit tests coverage * Fix variable names --------- Co-authored-by: Mohit Ruwatia <120438312+mon4our@users.noreply.github.com> Co-authored-by: Hardik Goyal <135348086+HardikGoyal2003@users.noreply.github.com>
…25632) * added the files related to ckeditor migration * added files * added * added all files * added package.json * final push of working changes * final push of working changes * Revert "added files" This reverts commit df2cdfb. * fixed linters and also removed packages from dependencies.json * fixed linters and also removed packages from dependencies.json * changing verison of package + adding tarbell url * changing verison of package + adding tarbell url * adding tarbell url to make the version consistent * adding if else method * adding if else method * adding if else method * added * fixed linters * used buil.py to copy ckeditor * added copy evendor logc * done * Update core/templates/third-party-imports/ckeditor.import.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update CKEditor import path in ckeditor.import.ts * adding ckeditor fixes * changes done related to the migration * done * added * added * added * added * changed acceptance test * changed * done * done * done --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Hi @jayam04, can you complete the following:
|
|
Hi @U8NWXD, @kevintab95, PTAL at this PR, it modifies files in jobs or platform folders. |
|
Hi @U8NWXD, @kevintab95, PTAL at this PR, it adds a new cron job. |
|
Hi @U8NWXD and @kevintab95, PTAL at this PR, it adds new models that need to be validated. The models are VoiceoverRegenerationJobModel, VoiceoverRegenerationBatchExecutionModel, ExplorationOpportunitySummaryAuditModel. |
|
Hi @jayam04 please assign the required reviewer(s) for this PR. Thanks! |
|
Assigned reviewers: @U8NWXD, @kevintab95. Thank you! |
|
Hi @jayam04, there are some failing CI checks in your latest push. If you think this is due to a flake, please file an issue before restarting the tests (see instructions). Thanks! |
jayam04
force-pushed
the
force-push-test
branch
from
April 24, 2026 05:16
701c665 to
49e1dc5
Compare
|
Hi @jayam04, force pushing is not allowed as it makes code reviews hard. You can learn more about this here (point 3). I’ll be closing this, please make a new PR with the required changes. Thanks! |
|
Assigned reviewers: @U8NWXD, @kevintab95. Thank you! |
|
Hi @jayam04, force pushing is not allowed as it makes code reviews hard. You can learn more about this here (point 5). I’ll be closing this, please make a new PR with the required changes. Thanks! |
|
Assigned reviewers: @kevintab95. Thank you! |
|
Hi @jayam04, can you complete the following:
|
|
Hi @jayam04, there are some failing CI checks in your latest push. If you think this is due to a flake, please file an issue before restarting the tests (see instructions). Thanks! |
jayam04
force-pushed
the
force-push-test
branch
from
April 24, 2026 05:22
49e1dc5 to
ed633b4
Compare
|
Hi @jayam04, force pushing is not allowed as it makes code reviews hard. You can learn more about this here (point 3). I’ll be closing this, please make a new PR with the required changes. Thanks! |
|
Hi @jayam04, force pushing is not allowed as it makes code reviews hard. You can learn more about this here (point 5). I’ll be closing this, please make a new PR with the required changes. Thanks! |
|
Hi @jayam04, can you complete the following:
|
|
Hi @jayam04, as mentioned previously, force pushing is not allowed. Please make a new PR. Thanks! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
the cause of the bug was, and which PR introduced it]
Essential Checklist
Please follow the instructions for making a code change.
Testing doc (for PRs with Beam jobs that modify production server data)
Proof that changes are correct
Proof of changes on desktop with slow/throttled network
Proof of changes on mobile phone
Proof of changes in Arabic language
PR Pointers