G so c m1.7.6 - #118
Merged
Merged
G so c m1.7.6#118
Conversation
…d-list-editor (oppia#25309) * Fix oppia#18103: Resolve duplicate IDs and add missing aria-labels * Fix unique row IDs and add aria-labels to schema-based-list-editor * Fix linting: exact indentation for line 46 * Fix: final indentation for line 46 and resolved linting issues * Fix: update acceptance test selectors to handle dynamic accessibility IDs * Fix oppia#18103: Update selector in moderator utility to match dynamic row IDs --------- Co-authored-by: Kartik Suryavanshi <158498247+KartikSuryavanshi@users.noreply.github.com>
…st (oppia#25924) * extracted study guide update logic * updated line no * trigger CI * update comment
…entsTab.js E2E tests to acceptance tests (oppia#25280) * migrated e2e to acceptance tests * fixed test * changed screen shot * changes ss * changed ss again * addded site change function * removed comments * new changes * fixed lint errors * fixed lint checks * made changes based on review * additional changes * removed confetti check * removed comment * fixed lint issues * removed function * fix 1
…rrors (oppia#25670) * Detect server errors and explicitly fail full-stack acceptance test runs * Ignore known version history handler 500 errors to fix CI tests
oppia#25712) * Fix: Navbar tooltips appear when hovering full editor tile * Fix: Navbar tooltips appear when hovering full editor tile --------- Co-authored-by: NITISH KUMAR <imnitishkumar04@gmail.com>
…ization arg (oppia#25897) * Fix NumericExpression division symbol display per customization arg * Add coverage tests for exploration html formatter numeric expression branches * Remove stale ts-expect-error directives in formatter spec
…unctions in apply_change_list (oppia#25855) * extract cmd handling into small functions * fix CI failure by adding proper comment * resolve merge conflicts
…e during typing (oppia#25930) * Fix 20694 Resolve search bar layout shift on community library page * updated css
…sicNotes, CodeRepl, GraphInput, InteractiveMap) from UI (oppia#25506) * Removed unused interactions from frontend * Fixed a failing unit test * Fixed a failing unit test * Removing other unused interactions * Fixing lint errors * Fixing failing tests * Fixing lint errors * Fixing failing tests * Fixing failing test * Addressing review comments
… missing aria-labels (oppia#25826) * Fix missing aria-labels on About page feature close buttons * Refactor about page partnerships and CTA sections into reusable components * Lint fix * Refactor about page CTA volunteer carousel into shared template * Improve accessibility for about page mobile feature panels * Minor fix * Fix frontend tests coverage * Fix I18n keys ordering * Removed unnecessary test
…n the Topics and Skills dashboard (oppia#24552) * Add question editor role to question-admin * Fixed an issue in the topic navigation bar component * Resolve linter errors * resolve frontend issue * Fix typscript issue * Fixes TS checks! * Fixes TS checks! * Fixes Backend Test * Fixes Backend Test Coverage * fixes role services * remove QuestionAdminHandler and fixes backend test * fixes lint checks * fixes backend function and add test case * fixes lint checks * resolve typscript error * resolve lint checks error * Remove unnecessary actions from the question admin. * fixes backend test case * Resolve TypeScript checks * fixes typescript checks
…ge (oppia#25790) * Automatically clear status message on blog admin page * Add tests and fix existing tests * Change timeout to 10 seconds * Use toast with fadeout for status message on blog admin page * Add one more test * Use AlertsService * Fix E2E acceptance tests * Fix frontend tests * Try to fix acceptance test * Don't wait for toast to disappear
* Add HTML linter check for new embedded style tags * Added a file in the allowlist * Address review comments
…e feedback (oppia#25672) * Fix: No validation for Message text and Thread subject inside feedback * Remove alphanumeric-only feedback validation, added testcase for whitespace, changed MESSAGE_MIN_CHAR_LIMIT and tried to solve CI failures * fixed the error display for min_char_limit violation * rewriting tests and fixing i18n
…ricInput (oppia#25808) * Fix oppia#10899: Add validation to prevent negative tolerance in NumericInput * Fix oppia#16667: Add frontend validation for negative selection counts and sync LC.2 tests * Remove acceptance tests per reviewer feedback * Remove acceptance tests per reviewer feedback * Add unit tests for isRuleValid to fix frontend coverage * Fix TypeScript strict mode types for boolean expectations * Chore: Remove accidentally included ItemSelection files * Fix: Sync ItemSelection files with official upstream to clear TS errors * Fix: Restore UI validation and prevent service math crash * Chore: Update validation strings to include 'value of' per reviewer feedback * Address review: Implement type-safe validation and resolve UI redundancy * Fix: Address final reviewer nits on HTML formatting and whitespace
…t tests (oppia#25992) use relative dates in tests to avoid expiry failures Co-authored-by: mosin74 <mosin74@gmail.com>
…nput (oppia#26016) Solved acceptance test
…symbol dict (oppia#25959) removing unecessary parentheses from fraction symbol dict
…nteractions (oppia#25993) * Fix oppia#18515: Implement detailed redundancy validation for TextInput to prevent backend crashes * Test files Added
…7,18,19,23 (oppia#25936) * Enforce strict typescript checks for group 17,18,19,23 * Fixed lint checks and frontend tests * fixed type checks * fixed lint checks * fixed lint checks and frontend tests * fixed frontend tests * Fixed frontend coverage * removed unknown type * Fixed frontend tests * removed comments * Fixed type check
… sort acceptance test (oppia#25962) waiting for element to stabilize before dragging
…ns in blog search acceptance test to fix flaky failures (oppia#25954) * waiting for specific selectors * using expectElementToBeVisible
* Fix NumberWithUnits non-currency invalid input error * Refine NumberWithUnits invalid input classification * Refactor NumberWithUnits currency-prefix validation * Simplify NumberWithUnits currency prefix checks * Refine NumberWithUnits input normalization and digit parsing
…ppia#25746) * Fix oppia#25307: Stop email retries for permanent 4xx client errors * fixing CI * fixing CI * fixing CI * removed 429 and 408 after discussion * fixing CI * adding test coverage * fixed the infinite feedback loop
…ppia#25871) * Fix oppia#25710: Implement RecoverOrphanedTranslationsJob to restore historical translations * Add new test to backend test shards * Add new test to linter valid_job_imports check * Inline mapping functions based on codeowner review
…fo first and then emitting events (oppia#25306) * added feature and tests * fixed lint * removed as * removed async * fixed tests * resolved frontend errors * resolved bugs * resolved frontend errors * added review suggestions * template ready * final * fixes issues in frontend tests due to addn of async in GAservice * Revert "fixes issues in frontend tests due to addn of async in GAservice" This reverts commit bcd93bc. * add debug mode * correcting the flow of getting userinfo first and then emitting events * added gtm script for main page * unmerged it from local GA branch * fixed failing errors related to ts * fixed failing errors related to ts * fixed failing errors related to ts * changed approach, instead of using dom, added script directly to the header_js * reverted GA and GTM ID * reverted GA and GTM ID * removed unnecessary changes * removed unnecessary changes * added the html files * removed hardcoded ga and gtm ids
…_list (oppia#25943) * Extract subtopic page update logic from apply_change_list * Fix lint issues * Fix: apply Black formatting * Fix: correct subtopic page change logic and study guide sync * fixed lint checks * Fix lint issues and cast comments in topic services --------- Co-authored-by: Kartik Suryavanshi <158498247+KartikSuryavanshi@users.noreply.github.com>
…pply_change_list (oppia#26087) * refactored subtopic page preprocessing logic * correct ref line no * fix CI checks * fix CI errors
…diff (oppia#26079) * Fixed the flake * changed the logic * changed the logic * changed the logic * fixing Ci fail * changed the logic * changed the logic * changed the logic
…ppia#26107) Co-authored-by: Kevin Thomas <kevintab@mbp.local>
…or multi-entity support (oppia#26360) [GSoC 2026] M 1.7 - Fix part of oppia#24933: Update pinning handler for mixed-entity support Co-authored-by: NITISH KUMAR <imnitishkumar04@gmail.com>
…sessment Offering Creation and Retrieval Services (oppia#26333) * Created services and function for get,create certificate assessment * Lint checks * Lint checks * Update test file, Fix lint and mypy check * Lint checks * Added issue number in todo comment * Added test test file in backend_test_shards,json * Respond to the coderrabit comments * Fixed lint checks and added coverage for missing lines * Fix lint check * strict type check issue resolved --------- Co-authored-by: mosin74 <mosin74@gmail.com>
…er/completes-the-exploration-and-decides-what-to-do-next (oppia#26321) * Setting up playwright node * Implemented M1.2 and M1.3 and M1.4 * Moved common mocks to setUp * Migrated add-and-remove-exploration to playwright * Exclude playwright acceptance tests from frontend test runner * Removed puppeteer spec * Exclude playwright directory in root-files-mapping-generator * Exclude playwright-acceptance-tests from root TS and Karma configs * Migrated completes-the-exploration... to playwright * Replaced fullstop * Addressed comments * Fixing lint * Revert "Merge branch 'develop' into GSoC-M1.8.2" This reverts commit a37aa73, reversing changes made to 905b61f. * Revert "Revert "Merge branch 'develop' into GSoC-M1.8.2"" This reverts commit 9c8cb5a. * Recover changes
…for lesson card (oppia#26390) * checkpoint bar * fixed checkpoint * finalised checkpoint bar component * fixed frontend and type checks failure * fixed frontend failures * fixed frontend coverage * fixed frontend errors * removed unreachable tests * remove unused code * fixed type checks * fixed lint checks * addressed coderabbit's comments * fixed frontend tests * fixed lint and frontend coverage tests * removed changes in exploration-engine.service file * removed duplicate code * fixed tests * fixed type checks
… to acceptance test (oppia#26269) * migrated-e2e-navigation.js * updated tests according to updated cuj * Merged it blocks * Added framework * Updated acc to CUJ * Following exactly CUJ * Updated according to CUJ SE.1 * Using i18n in constants.ts
…t IDs using generic translation opportunities (oppia#26327) * Implement and test suggestion resolver for new translation opportunity models gated by Feature Flag * Fix backend coverage * Fix mypy type annotation errors and format suggestion_test.py * Fix mypy type annotation errors, string quotes and format suggestion_test.py * Address review comment: Use ExplorationOpportunitySummary domain object in suggestion.py * Refactor suggestion opportunity dict to reuse service layer helper * Restore scripts/run_acceptance_tests.py to match develop --------- Co-authored-by: NITISH KUMAR <imnitishkumar04@gmail.com>
…r dashboard test (oppia#26131) * Solve the flake * changed logic * Checking the real cause * again trying to find the root cause * again trying to find the root cause * again trying to find the root cause * added the logic * again trying to find the root cause * again trying to find the root cause * Trying new logic * minior fix * addition in the logic * using waitforselector instead of waitforfunction
…g animation waits (oppia#26057) * wait for state-graph modal to close before proceeding on mobile * fix drag-and-drop sort flake on mobile by awaiting modal close and stabilizing drag operations
…ppia#26340) Fix the concept-card-modal-dismiss-error
….1_PR2_PR_3 (oppia#26408) * GSoC_2.1_PR2 * added service layer changes * fixed mypy and lint * fixed mypy and lint * fixed mypy and lint * added abstract class, api constatnts and units tests * fixing mypy and lint * added tests * fixed backed test * fixing backend * updated backend test * edited model
…e Certificate Offering Flow UI, (Add Topic item) (oppia#26319) * Add feature flag and stub handler with UI skeleton behind the feature flag * Replace BaseModule with SharedModule * Add **kwargs to decorator and rename feature flag * Lint checks * Inital changes and stucture for create certificate offering skeleton * Inital changes and stucture for edit certificate offering * Initial changes for editing the Certificate Offering model and added delete popup and get by id handler for certificate offering * Added auth guard for and fix failling test lint and mypy once * Add coverage for certificate assessment model and edit certificate page root component * Update 1.4 with learner assessment1.3 and updated folder stucture * Reverted unwanted changes * Stub UI for add topic page is created * Removed comments from add-topic compoent and added some CSS * fix: Adjust emitted event expectation in add topic items modal test Co-authored-by: aider (gemini/gemini-2.5-flash) <aider@aider.chat> * fix: Ensure topic data is emitted on next click Co-authored-by: aider (gemini/gemini-2.5-flash) <aider@aider.chat> * Removed redundunt logic from add-topi-items.components.ts * Lint checks * Added css for radius, width related changes and padding, added todo comment * Lint check * Used dot notation * Removed duplicate import * Fix stale/incorrect topic hydration --------- Co-authored-by: mosin74 <mosin74@gmail.com> Co-authored-by: aider (gemini/gemini-2.5-flash) <aider@aider.chat>
oppia#26323) * Add direct link to dataflow page * fixing tests * fixing tests * fixed frontend tests * Re-run CI * Addressed review comments * Addressed review feedback * Fix backend validation tests and frontend strict type errors * Fixing tests * Re-run CI * Re-run CI
…er/sets-goal-on-learner-dashboard to playwright (oppia#26329) * Setting up playwright node * Implemented M1.2 and M1.3 and M1.4 * Moved common mocks to setUp * Migrated add-and-remove-exploration to playwright * Exclude playwright acceptance tests from frontend test runner * Removed puppeteer spec * Exclude playwright directory in root-files-mapping-generator * Exclude playwright-acceptance-tests from root TS and Karma configs * Migrated completes-the-exploration... to playwright * Migrated sets-goal-on-learner-dashboard to playwright * add serial mode * Fixing errors * Created constant for video rec dir
…tion infrastructure to support V2 generic architecture (oppia#26337) * Fix part of oppia#24933: Migrate frontend translation infrastructure to support V2 generic architecture * Fix TranslationModalComponent unit tests by mocking PlatformFeatureService * Fix ContributionOpportunitiesBackendApiService unit test coverage for V2 integration * Fix ContributionsAndReview unit tests for V2 integration and support EnableTranslationOppsWithNewOppModels flag * Fix dashboard undefined values by adding V2 backwards-compatibility fields * Address review feedback: Revert V2 model representation changes, add frontend mapping layer, and implement V2 translatable content filtering with test coverage * Fix frontend opportunity spec mocks and correct language code mapping under V2 * Address review comments on V2 translation generic architecture migration * fix linters punctuation * Fix mypy type annotation and run black formatting on suggestion_services * Fix backend tests for contributor dashboard and opportunity domain * Add unit tests to cover generic state name resolution and stale translation check in suggestion_services * Associate topic IDs with V2 translation opportunities during creation and regeneration * Fix V2 translation opportunity integration issues * Fix backend unit test coverage check for suggestion controllers * Fix mypy type annotations in suggestion_test.py * Address review comments on suggestion tests and default language code * Mock PlatformFeatureService in TranslationOpportunitiesComponent unit tests * Fix state name dependency in generic V2 translation infrastructure by introducing grouping_key * Address mentor review comments for translation opportunity V2 migration * Create ExplorationContextModel during initial story creation * Fix: Contributor dashboard opportunity list refresh and progress bar rendering * Fix mypy errors in opportunity_services.py * Fix lint errors in suggestion_test and scripts * Fix script formatting properly to bypass black squash * Revert script files changes * Fix bugs in opportunity_services.py causing failing tests * Fix bugs in opportunity_services.py causing failing tests * Address mentor review comments and fix backend test coverage for translation opportunities * Fix backend coverage for legacy translation update path
…tionConfirmationModalComponent and PostCertificateOfferingCreationModalComponent UI (oppia#26330) * Add feature flag and stub handler with UI skeleton behind the feature flag * Replace BaseModule with SharedModule * Add **kwargs to decorator and rename feature flag * Lint checks * Inital changes and stucture for create certificate offering skeleton * Inital changes and stucture for edit certificate offering * Initial changes for editing the Certificate Offering model and added delete popup and get by id handler for certificate offering * Added auth guard for and fix failling test lint and mypy once * Add coverage for certificate assessment model and edit certificate page root component * Update 1.4 with learner assessment1.3 and updated folder stucture * Reverted unwanted changes * Revert unintended changes in index.yaml, certificate-assessment-domain.constants.ts, and certificate-offering-dashboard-page.component.ts * Added TODOs and type cleanup for the certificate offering skeleton, switched breadcrumb/navigation to Angular routerLink, and handled delete failures with warning feedback plus tests. * Update delete modal UI to match design * Add confirmation modal and post-confirmation modal * Fix lint checks * Fix lint checks * Fixed coverage and failing test and coderrabit comments * Fix failing test * Lint checks * Updated components to use const * Lint checks * Created shared actions and statuses for certificate offering flow * Added coverage for missing line * Move constants to existing constants file * fix import issue --------- Co-authored-by: mosin74 <mosin74@gmail.com>
…er/provide-feedback-on-the-lesson-or-report-it-from-the-lesson-player to playwright (oppia#26332) * Setting up playwright node * Implemented M1.2 and M1.3 and M1.4 * Moved common mocks to setUp * Migrated add-and-remove-exploration to playwright * Exclude playwright acceptance tests from frontend test runner * Removed puppeteer spec * Exclude playwright directory in root-files-mapping-generator * Exclude playwright-acceptance-tests from root TS and Karma configs * Migrated completes-the-exploration... to playwright * Migrated sets-goal-on-learner-dashboard to playwright * Migrated provide-feedback * fixed flake * testing * testing * testing * removing unnecessary log * removing unnecessary log * correctly skipping the test for mobile * Fixing lint * Fixing lint * Added TODO * Undo unnecessary change * Fixing lint formatting
… dashboard (oppia#26084) * Fix oppia#22513: Implement backend-driven skill search in contributor dashboard * UNIT TESTS * Add frontend and backend unit tests * Update dev mobile snapshots with Dev Mode label * Update prod mobile snapshot to match CI resolution * Update prod mobile snapshot to match CI resolution * Address review comments: Refactor search_query logic, extract debounce constant, and enforce strict type safety on query parameters * Fix Angular AOT strict signature mismatches for search query bindings * Fix strict template compilation error for search input event due to recent develop branch updates * Apply code formatter changes to clean working directory * Addressing Reviewer Comments including inline comment, searchquery etc
…e and reverted code related to old CUJs. (oppia#26397) * updating the old code according to cujs * added unit tests to all the parent files * unit tests added for the modal files * added unit tests for moals and backend API service * added unit tests for moals and backend API service * added unit tests for moals and backend API service * fixed ts errors * fixed ts compilation issues * fixed ts errors * fixed ts errors * fixed ts errors * fixed lint errors * fixed ts compilation issues * fixed lint errors * added I18N tags * fixed order of I18N keys * corrected order of I18N tags * corrected order of I18N tags * made suggested changes * made suggested changes * made suggested changes * fixed ts errors * addeed customformsComponentsmodule to baseModule * fixed ts errors * fixed ts errors * reverted changes * fixed ts errors * added I18N tags * added I18N tags * added I18N tags * fixed I18N error * fixed last I18N bug * acorrected error * Update tsconfig-strict.json
…ia#26270) * remove creator dashboard * remove creator dashboard * remove creator dashboard * remove creator dashboard * remove creator dashboard * fix flakiness * fix flakiness * fix flake * fix flake * fix flake * fix tests * delete subscriptionDashboard * address comments * fix tests * fix lint * fix test * fix test * fix test * increase timeout * update ss * address comments * update mobile dev mode ss * fix tests * address comments * fix lint
…#25774) * Add acceptance tests for question editor modal (oppia#8704) * Add e2e-test selector to Link Another Skill button * Fix Question Editor flakiness and backend version mismatch issues * Fix oppia#8704: Stabilize Question Editor tests, sync backend API contract, and resolve all frontend linting issues * Refactor Question Editor for stability * Improve acceptance test robustness * Fix oppia#8704: Update Question Editor acceptance tests to match approved CUJs and UI behavior * Fix TypeScript compilation error: add ExplorationEditor to TopicManager type union * Fix: Restore 10-minute timeout for long-running setup phase * Cleanup: Remove explicit timeout before final submission * Fix async race condition in Topic Manager acceptance tests * Address CodeRabbit & reviewer feedback on accessibility, formatting, and 404 handlers * Add tests for 404 missing question handlers for missing coverage * Fix mypy errors for mock returns in missing question tests * Fix 404 test coverage failures in question editor controller tests * Address review comments on question editor acceptance tests * Address reviewer comments: use expectElementToBeVisible and dynamic waiting instead of timeouts * Refactor topic-manager question/skill helpers to address minor review comments --------- Co-authored-by: NITISH KUMAR <imnitishkumar04@gmail.com>
…er/access-pages-that-require-higher-privileges and logged-in-learner/goes-through-the-sign-in-flow to playwright (oppia#26339) * Setting up playwright node * Implemented M1.2 and M1.3 and M1.4 * Moved common mocks to setUp * Migrated add-and-remove-exploration to playwright * Exclude playwright acceptance tests from frontend test runner * Removed puppeteer spec * Exclude playwright directory in root-files-mapping-generator * Exclude playwright-acceptance-tests from root TS and Karma configs * Migrated completes-the-exploration... to playwright * Migrated sets-goal-on-learner-dashboard to playwright * Migrated provide-feedback * fixed flake * testing * testing * testing * removing unnecessary log * removing unnecessary log * Migrated access-pages-that-require-higher-privileges * Migrated goes-through-the-sign-in-flow * correctly skipping the test for mobile * add serial mode * Fixing lint * Fixing lint * Fixing lint * Fixing lint * Fix errors * Fixing mobile skip * Added TODO * Fixing lint * Undo unnecessary change * Fixing lint formatting
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
the cause of the bug was, and which PR introduced it]
Essential Checklist
Please follow the instructions for making a code change.
Testing doc (for PRs with Beam jobs that modify production server data)
Proof that changes are correct
Proof of changes on desktop with slow/throttled network
Proof of changes on mobile phone
Proof of changes in Arabic language
PR Pointers