v2: fixes and hardening from review of #6–#8 by jaykv · Pull Request #9 · jaykv/mongospecs

jaykv · 2026-10-13T06:32:16Z

Stacked on #8. A second session reviewed the three v2 PRs and reported five reproduced bugs plus read-only findings. I reproduced each bug with a failing test before fixing it; reproducing them turned up one more (cyclic cascades recursed forever).

Bugs fixed (commit 1)

Reported	Fix
`select()` + `sort()` + cursor `page()` repeated documents and never terminated	Sort keys are always part of the projection; the next cursor was being built from defaults
`Location` after a create was a bare id	It is now a URL under the API prefix, set by `Api` (which knows where the resource is mounted)
`bulk_save` left memory out of sync after a partial failure	Writes are independent: successes are re-tracked and the error lists the failures in `.failed`. The server only reports a total, so on a mismatch the documents are read back and compared with what each update should have written
`bulk_write` hard deletes skipped `OnDelete` cascades	Cascades run first, in the same transaction, as for single deletes
Saving a `copy.copy()` of a tracked document raised a bare `DuplicateKeyError`	The error now says the instance is not tracked (copy, deepcopy, lean, unpickled) and what to do
(found while reproducing) a cycle of cascading references recursed until the stack overflowed	Cascades carry the set of documents already being deleted

Also from the read-only findings: cascades read ids with find and work in chunks instead of distinct() and one unbounded $in; reload() no longer loads Deferred fields; Query.update() returns an int that also carries .matched.

Web hardening (commit 2)

Request bodies are size-limited while being read on every plug. Previously Starlette, FastAPI, Litestar and Quart buffered the whole body before the check.
DELETE applies the row scope in the delete's own filter and honours If-Match. Hard deletes of a loaded document are now revision-checked too.
Offset pagination refuses pages deeper than max_offset (10,000 skipped documents by default).
Reads made for a request get a 10 s time limit when neither the registry nor the model sets one.
Api(openapi=False), HEAD/OPTIONS on Api.handle and the pure ASGI plug, and Resource(explicit_writes=True) for default-deny field policy.

Breaking: ?total=true is now opt-in per resource (page=Cursor(total=True)).

Follow-ups (commit 3)

docs/parity.md: 28 of 35 Mongoose behaviours are now confirmed against its documentation; 7 are still from memory and marked.
CI covers MongoDB 7.0 on Python 3.11, 3.13 and 3.15; the publish workflow runs the checks before publishing.
Plan amendments A25–A29 record the deviations the review pointed out.

PATCH and PUT on embedded objects (`933df43`, `ecb42e6`)

PATCH merges an object given for an embedded model into the stored one, key by key (RFC 7396), in one atomic update. Replacing it wrote defaults over everything the client did not send, including private, read-only and immutable values it is not allowed to set. Lists and dicts are still replaced whole. (A37)
Resource(merge_patch=False) turns the merge off for a resource: PATCH replaces the embedded object with the one sent. That is the way out when the embedded model has cross-field validators, when clients must be able to write over a stored null, or when the backend has no supports_merge. The cost is the hazard the merge removes: values the client cannot send go back to their defaults. Nested keys the policy closes are rejected either way. (A39)
New Put operation: PUT /{id} replaces every field the client may update (the sent value, or the default when left out; a required field must be sent) and leaves the rest as stored, with the same If-Match check. An embedded object holding protected values is replaced key by key; one without is replaced whole. It never creates. OpenAPI gains <Model>Put schemas. (A39)
Put is not in the default ops. Guards are keyed by operation, so adding it to the defaults would expose an unguarded write on resources that only guard Patch.

Breaking: clients that relied on PATCH replacing an embedded object must send null for the keys they want cleared, or the resource sets merge_patch=False.

Third review (`7a4012b`, `0c5388a`)

I reviewed the stack as one codebase and reproduced nine defects against the replica set. Each has a test that failed first (test_review_round3.py in both packages). Recorded as A40.

Defect	Fix
`Model.update()` and `PATCH` on a pydantic model failed a cross-field validator that only saw the other fields' defaults	The field's own validators run; the cross-field verdict is not taken for a single-field update
`NaN` and `Infinity` in a body were accepted and stored, then came back as `null`	Request bodies are strict JSON: 400
Deeply nested JSON was a logged 500	400
`If-Match` on a model without a `Revision` was ignored and the write went through	412 (`If-Match: *` passes)
The ASGI plug ran a request whose client had disconnected mid-body	The request is dropped
`Api(openapi=False)` did nothing on FastAPI	The routes are served but stay out of `/openapi.json` and `/docs`
`insert_many` and `bulk_save` skipped document hooks	They run them, as `insert` and `save` do
A bad cursor with `total=True` left an un-awaited coroutine	The count starts after the arguments are validated
A guard or hook keyed by an operation the resource does not have guarded nothing	`ValueError` when the `Api` builds its routes

Also: If-None-Match accepts lists, weak tags and *; the concurrency limit is applied before authentication; a filter or sort key given twice is a 400. CI ran every job twice per push (push and pull_request triggers); it now runs once. mongospecs[all] includes the otel and sentry extras.

insert_many running hooks departs from Mongoose, where insertMany does not run save middleware. A before("insert") hook that silently does not run loses data; the calls are skipped when no hook is registered.

Breaking: the 412 on If-Match without revisions, the 400 on repeated keys and on NaN/Infinity, and the ValueError on unknown guard keys.

Writes are validated (`1dac7f6`)

msgspec and attrs do not check types in the constructor or on assignment, and pydantic does not check assignments, so Counter(n="many").insert() stored a string and the document could not be loaded afterwards. insert, save, insert_many and bulk_save now check the document, in the form it is about to be stored in, and raise ValidationError. save checks only when something changed, and only the changed fields of a document loaded with a projection.

The check can be skipped with validate=False on a call or SpecConfig(validate_writes=False) on a model. It took about 3 µs (msgspec) and 5 µs (pydantic) per seven-field document in an ad hoc measurement; the recorded B4 benchmark predates it and was not re-run. Recorded as A41.

Documentation and repository (`c5eba4d`, `c23ffbc`)

examples/: a quickstart script, a to-do REST API with its tests, and a compose file for a one-node replica set. They run in the suite; the tutorial and the README include them as they are.
New pages: Getting started, Choosing a backend, Errors (with the HTTP status each becomes), Authentication and authorization, Testing your API. The last two are executed like the other guide pages.
The replica-set requirement is stated in the README, the landing page and the tutorial.
The generated reference section and mkdocstrings are removed.
CHANGELOG.md, CONTRIBUTING.md, SECURITY.md; a workflow that deploys the docs to GitHub Pages from main; the publish workflow refuses a tag that does not match the package version.

Two things to know before merging: the docs workflow will overwrite the existing gh-pages branch on the first push to main that touches docs, and SECURITY.md points at GitHub private vulnerability reporting, which has to be enabled in the repository settings.

Not changed, with reasons

Atlas Search and vector indexes (plan §4.6): declared out of scope for 0.2 in A26. They need Atlas to create and test; I would rather not ship them unverified.
Process-global bindings and tracking state: unchanged. A model class binds to one open registry; several registries or one per thread use registry.manager(Model), which is now documented. The suggested task-scoped "current registry" is not built.
Suggested additions (testing helpers, an indexes CLI, outbox/audit plugins, sub-resources, idempotency keys): not built; none is in the plan.

Verification

887 tests pass locally (unit, contract, end-to-end, docs examples, examples/) against MongoDB 8.0 on a replica set and a sharded cluster, with write validation on; ruff and mypy --strict are clean; docs build in strict mode. The example API was also started under uvicorn and called with curl. The chaos test (primary step-down) was not re-run for the later commits. The reviewer tested against MongoDB 6.0.1, which is below this project's floor of 7.0; I did not test on 6.0.

Still open: on framework plugs, trailing slashes, HEAD and OPTIONS follow the framework and differ between plugs (documented in docs/web/plugs.md). The third review did not read relations, indexes, change streams, bulk compilation, the fast-read path or the bench code.

🤖 Generated with Claude Code

Summary by Sourcery

Harden v2 database and web APIs against review-identified correctness, consistency, and resource-safety issues while expanding regression coverage and documentation.

New Features:

Add safer web API defaults and controls, including request-size limits, bounded reads, capped offset pagination, conditional deletes, private OpenAPI support, HEAD/OPTIONS handling, and explicit write policies.
Support absent None defaults, reserved-field validation, consistent query casting, invalid-document read modes, non-nesting transaction protection, and richer update results.

Bug Fixes:

Fix cursor pagination with projections, resource Location URLs, partial bulk_save state synchronization, hard-delete cascades, untracked-copy save errors, deferred-field reloads, and cyclic cascade recursion.
Ensure request bodies are limited while streaming and DELETE operations enforce scope and revision conditions.

Enhancements:

Harden cascade processing with chunking and visited-document tracking, and improve bulk operation error reporting and cascade behavior.
Expand documented Mongoose parity coverage and record reviewed deviations and out-of-scope functionality.

CI:

Test MongoDB 7.0 across Python 3.11, 3.13, and 3.15, and verify linting, typing, and tests before publishing.

Documentation:

Document new model, query, write, transaction, pagination, web security, registry, and framework-plug behavior.

Tests:

Add regression and contract coverage for review findings across database backends and web framework plugs.

Each has a regression test that failed before the fix. - cursor pagination with select() repeated documents and did not terminate: sort keys were left out of the projection, so the next cursor was built from defaults. Sort keys are now always fetched - bulk_save left memory out of sync after a partial failure. Writes in the batch are independent; the ones that succeeded are now brought in sync and the error lists the rest in .failed. Which updates applied is determined by reading the documents back, since the server only reports a total - bulk_write hard deletes skipped OnDelete cascade rules - a cycle of cascading references recursed forever; cascades now carry the set of documents already being deleted - cascades resolved ids with distinct() (16MB limit) and one unbounded $in; ids are now read with find and applied in chunks - saving an untracked instance that has an id (a copy, a deepcopy, a lean read) raised a bare duplicate-key error; it now says the instance is not tracked and what to do - reload() loaded Deferred fields - Query.update() returns an int that also carries .matched - the Location header of a create was a bare id; it is now a URL under the API prefix Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

From review of the web layer. - request bodies are read under the size limit on every plug (declared length checked first, then chunk by chunk); previously only the pure ASGI plug stopped at the limit and the others buffered the whole body - DELETE applies the row scope in the delete's own filter, not only in the lookup before it, and honours If-Match - deleting a loaded document checks its revision on hard deletes too - offset pagination refuses pages deeper than Pagination.max_offset (10,000 skipped documents by default) - totals are opt-in per resource: Pagination.total now defaults to False - reads made for a request carry a 10s time limit when neither the registry nor the model sets one - Api(openapi=False) keeps the API description private on every plug - HEAD and OPTIONS are answered by Api.handle and the pure ASGI plug - Resource(explicit_writes=True): a field is writable only when its Policy says so - mongospecs_web.testing.mount_on(plug, api) builds an app on any built-in plug BREAKING: ?total=true needs page=Cursor(total=True) / Offset(total=True). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

- parity page: 28 of 35 Mongoose behaviours now confirmed against its documentation; three more deliberate differences recorded - plan amendments A25-A29: the computed decorator, Atlas Search and vector indexes declared out of scope for 0.2 (not testable here), revision-checked hard deletes, the changed web defaults - guides: limits and defaults of the web layer, untracked documents, partial bulk_save failures, registries and explicit managers - CI: MongoDB 7.0 on Python 3.11, 3.13 and 3.15 - publish workflow runs lint, types and the test suite first Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

sourcery-ai · 2026-10-13T06:32:21Z

Sorry @jaykv, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 6 days and 10 hours by commenting @sourcery-ai review. Upgrade to get a review now.

coderabbitai · 2026-10-13T06:32:26Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: dce8b26c-e1cc-435c-ba1e-ce17c80bda9f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

sourcery-ai · 2026-10-13T06:32:35Z

Reviewer's Guide

This PR hardens the v2 core and web layers against reproduced review defects: write and cascade operations now reconcile partial outcomes safely, pagination and tracking preserve correctness, HTTP requests and deletes enforce bounded and conditional behavior, and the supported integrations, documentation, and CI receive matching regression coverage and defaults.

Sequence diagram for safe bulk save reconciliation

sequenceDiagram
    participant App
    participant Manager
    participant MongoDB
    participant Documents

    App->>Manager: bulk_save(docs)
    Manager->>MongoDB: bulk_write(updates, ordered=False)
    MongoDB-->>Manager: write result or OperationFailed
    alt partial failures or matched count mismatch
        Manager->>MongoDB: find(ids)
        MongoDB-->>Manager: current documents
        Manager->>Manager: compare applied updates
        Manager->>Documents: re-track successful documents
        Manager-->>App: error.failed = unsuccessful documents
    else all writes succeed
        Manager->>Documents: re-track all documents
        Manager-->>App: written count
    end

Sequence diagram for conditional scoped deletion

sequenceDiagram
    actor Client
    participant Api
    participant Resource
    participant MongoBackend
    participant MongoDB

    Client->>Api: DELETE /resource/id with If-Match
    Api->>Resource: dispatch Delete
    Resource->>MongoBackend: delete(id, scope, if_rev)
    MongoBackend->>MongoDB: find document by id and scope
    MongoDB-->>MongoBackend: loaded document
    MongoBackend->>MongoDB: delete with scope and revision filter
    alt revision or scope no longer matches
        MongoDB-->>MongoBackend: no match
        MongoBackend-->>Api: StaleDocumentError or DocumentNotFound
        Api-->>Client: error response
    else match succeeds
        MongoDB-->>MongoBackend: deleted
        MongoBackend-->>Api: success
        Api-->>Client: 204 response
    end

Sequence diagram for cycle-safe cascading deletes

sequenceDiagram
    participant Manager
    participant MongoDB

    Manager->>Manager: delete_many(filter, seen)
    Manager->>MongoDB: find matching ids
    MongoDB-->>Manager: ids in chunks
    Manager->>Manager: _cascade(ids, seen)
    Manager->>Manager: delete_many(cascade filter, _seen=seen)
    Manager->>Manager: skip ids already in seen
    Manager->>MongoDB: delete_many(chunk ids)
    MongoDB-->>Manager: deleted count

File-Level Changes

Change	Details	Files
Hardened core document writes, deletion cascades, pagination, and update result handling based on reproduced review defects.	Always project cursor sort keys so cursor pagination terminates without duplicate documents. Make bulk saves independently reconcile successful documents and report failed documents; improve untracked-copy save errors. Run hard-delete cascades transactionally, with chunked lookups/deletes and cycle detection. Preserve deferred fields on reload and return integer-compatible update counts with matched/modified metadata.	`packages/mongospecs/src/mongospecs/manager.py` `packages/mongospecs/src/mongospecs/query.py` `packages/mongospecs/src/mongospecs/bulk.py` `packages/mongospecs/src/mongospecs/relations.py` `packages/mongospecs/src/mongospecs/model.py` `packages/mongospecs/src/mongospecs/errors.py` `packages/mongospecs/tests/test_review_fixes.py`
Added request and API-layer hardening with safer defaults and conditional, scoped deletes.	Stream and enforce request body limits across ASGI, Starlette, FastAPI, Litestar, and Quart integrations. Add DELETE revision checks and apply row scope to the write filter, including loaded-document hard deletes. Cap deep offset pages, make totals opt-in, apply default request read timeouts, and support private OpenAPI. Add direct API HEAD/OPTIONS handling and prefix-relative Location headers. Add explicit default-deny write policies per resource.	`packages/mongospecs-web/src/mongospecs_web/api.py` `packages/mongospecs-web/src/mongospecs_web/backend.py` `packages/mongospecs-web/src/mongospecs_web/filters.py` `packages/mongospecs-web/src/mongospecs_web/plugs/asgi.py` `packages/mongospecs-web/src/mongospecs_web/plugs/starlette.py` `packages/mongospecs-web/src/mongospecs_web/plugs/fastapi.py` `packages/mongospecs-web/src/mongospecs_web/plugs/litestar.py` `packages/mongospecs-web/src/mongospecs_web/plugs/quart.py` `packages/mongospecs-web/src/mongospecs_web/policy.py` `packages/mongospecs-web/src/mongospecs_web/resource.py`
Expanded regression, contract, and integration coverage for the fixes and web behavior.	Exercise partial bulk failures, cascades, cyclic references, deferred reloads, cursor projections, and update counts. Run contract behavior through all supported web plugs and test body limits, conditional deletes, pagination limits, HEAD/OPTIONS, OpenAPI visibility, and write policy modes.	`packages/mongospecs/tests/test_review_fixes.py` `packages/mongospecs-web/tests/test_contract.py` `packages/mongospecs-web/tests/test_mongo_resource.py` `packages/mongospecs-web/tests/test_openapi_views.py` `packages/mongospecs-web/src/mongospecs_web/testing.py`
Documented implementation decisions, compatibility boundaries, and verification/publishing expectations.	Record review amendments A25–A29 and document registry-manager usage and untracked document behavior. Mark Mongoose parity rows confirmed against documentation and document new web defaults and limits. Run linting, strict typing, documentation checks, and CI verification before publishing across Python 3.11, 3.13, and 3.15 with MongoDB 7.0.	`claudedocs/v2-plan.md` `docs/guide/operations.md` `docs/guide/writes.md` `docs/parity.md` `docs/web/resources.md` `.github/workflows/ci.yaml` `.github/workflows/python-publish.yaml`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

Each has a regression test that failed before the change (tests/test_review_round2.py in both packages). core - a field whose default is None is not stored while it is None, and setting it to None unsets it; a unique sparse index no longer collides on stored nulls - field names that shadow the Document API raise ConfigurationError - registry.transaction() inside a running transaction raises unless independent=True (it would commit on its own) - UpdateCount formats as its int value in str() and f-strings - filter values are cast by one rule on every backend - empty Or()/Nor(), non-text prefix()/contains(), sort keys that are not field paths and server type mismatches raise QueryError - include() checks its path and strategy when the query is built - find().on_invalid('raise' | 'skip' | 'raw') web - integers beyond 64 bits are a 422 on create and patch, and an EncodingError is no longer a 500 - Quart: init_app installs BodyLimit, which reads API bodies under the limit before Quart queues them - a guard runs once per request however many places list it - OpenAPI publishes only referenced definitions and no private field - HEAD on the ASGI plug reports the length of the GET body BREAKING: optional fields that are None are omitted from stored documents, so an exists filter now means 'has a value'. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Private fields of embedded (non-document) models were serialised, writable and described in OpenAPI. They are now handled like private fields of the document itself, at any depth and inside lists, dicts, optionals and unions: never in a response (including included documents), a 422 'unknown field' when a client supplies one on create or patch, and absent from every published schema. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Leaving None-valued optional fields out of stored documents stays the default. StoreNone on a field, or none='store' on a model, stores an explicit null instead (OmitNone opts a field back out). Encoding, change tracking, update(), upsert defaults and the bulk paths follow the field's mode; loading never produces a spurious change in either mode. A unique sparse index over a field that stores null is refused with a pointer to a partial index. Also applies the omit rule to embedded pydantic models, which were encoded with their None values. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

- web GET list/get read stored documents with a projection of the readable fields and serialise them directly when that is certain to equal the model path; anything else falls back to the model - DELETE is one conditional write unless the model needs the document (delete hooks, cascades) - independent includes are loaded concurrently (not inside a session) - per_parent_limit on a reverse relation is applied on the server - tracked documents use one weak reference instead of weakref.finalize - Query._clone copies slots instead of re-running __init__ - routes are looked up by resource before patterns are tried fix(core): cursor pagination no longer skips or stops at documents without a value for a sort key Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Requests beyond the limit are answered at once with 503 and Retry-After instead of queueing for database connections. test: correctness of the optimised paths (tracking, clone, includes, per-parent limits, routing) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…om the stored document Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

- docs/guide/production.md: pool and timeout settings, backpressure, read and pagination choices, relations, writes, what needs a replica set; each item marked measured, tested or guidance - docs/benchmarks.md: hot paths before and after the review - bench/results: B9 before (49a32a9) and after (fb543de) - plan: decision per review finding, amendment A36 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

An ObjectId, Binary, Timestamp, Regex or Int64 inside a field typed Any (or dict[str, Any], list[Any]) made the JSON conversion fail, and the web layer answered 500: on pydantic for any ObjectId, on msgspec and attrs for the BSON types their serialiser does not know. All three backends now give the same JSON for such values, at any depth. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

A PATCH that gave an object for an embedded model replaced the stored object, writing defaults over everything the client did not send, including private, read-only and immutable values it is not allowed to set. Objects are now merged key by key (RFC 7396) in one atomic update; lists and dicts are still replaced whole. - nested keys are held to the embedded model's own Policy - an embedded object holding protected values cannot be set to null, and a list or dict of such objects cannot be replaced through PATCH - Policy(insert=False) is enforced on nested keys at create - the OpenAPI Patch schema describes embedded objects as partial BREAKING: clients that relied on PATCH replacing an embedded object must now send null for the keys they want cleared. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

PATCH merging into embedded objects (A37) had no way out for resources that need the embedded model validated whole, need to write over a stored null, or use a backend without supports_merge. - Resource(merge_patch=False): PATCH replaces an embedded object with the one sent. Values the client cannot send go back to their defaults; nested keys the policy closes are still rejected. - Put: PUT /{id} replaces every field the client may update (the sent value, or the default when left out) and leaves the rest as stored, in one atomic update with the If-Match check. An embedded object holding protected values is replaced key by key; one without is replaced whole. It never creates, and is not in the default ops. - OpenAPI gains <Model>Put schemas where a resource has the operation. Recorded as A39 in the plan. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Each was reproduced against the replica set before it was fixed; the tests are in test_review_round3.py of both packages. Core - A single-field update on a pydantic model failed a model-level validator that only saw the other fields' defaults. The field's own validators still run; the cross-field verdict is no longer taken. - insert_many and bulk_save run document hooks, as insert and save do. - page() starts its count after its arguments are validated, so a bad cursor no longer leaves an un-awaited coroutine. Web - Request bodies are strict JSON: NaN, Infinity and over-deep nesting are a 400 (NaN was stored; deep nesting was a logged 500). - If-Match on a model without a Revision is a 412, not an unconditional write. If-None-Match accepts lists, weak tags and *. - The ASGI plug drops a request whose client disconnected mid-body. - Api(openapi=False) is honoured by the FastAPI plug. - Guards and hooks must name an operation the resource has. - The concurrency limit is applied before authentication. - A filter or sort key given twice is a 400. Recorded as A40 in the plan. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Branch pushes and their pull requests both triggered CI, so every job ran twice. mongospecs[all] now includes the otel and sentry extras, and mongospecs-web declares msgspec as the optional encoder it already uses when present. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

A new user had reference-quality guides and no way into them. - examples/: a quickstart script, a to-do REST API with its tests, and a compose file for a single-node replica set. They are run by the suite, and the tutorial page and the README show them as they are. - docs/tutorial.md: from MongoDB to a model, an API and its tests. - New guides: choosing a backend, errors (what each means and the HTTP status it becomes), authentication and authorization, testing an API. The last two are executed like the other guide pages. - The replica-set requirement is stated in the README, the landing page and the tutorial instead of only in the production notes. - The package README is checked to be the root README. - The reference section is removed: it was generated from docstrings, and the source is the better reference. mkdocstrings goes with it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

- CHANGELOG.md, CONTRIBUTING.md and SECURITY.md. - A workflow deploys the documentation to GitHub Pages from main. - The publish workflow refuses a release tag that does not match the version in the package it names. - Package metadata links to the documentation and the changelog. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

msgspec and attrs do not check types when a model is constructed or assigned to, and pydantic does not check assignments. A wrongly typed value was therefore stored as it was, and the document could not be loaded afterwards. insert, save, insert_many and bulk_save now decode the document's own encoding with the backend's strict rules before sending anything, and raise ValidationError if it does not fit. save checks only when there is a change, and only the changed fields of a document loaded with a projection. The check can be skipped with validate=False on a call or SpecConfig(validate_writes=False) on a model. It cost about 3 µs (msgspec) and 5 µs (pydantic) per seven-field document when measured. Recorded as A41 in the plan. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Move the site config to zensical.toml on the new default theme, swap the docs dependency, and deploy through the GitHub Pages actions since zensical has no gh-deploy. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

jaykv and others added 3 commits October 13, 2026 02:23

jaykv and others added 17 commits October 13, 2026 02:44

bench: B9, CPU per call and commands per operation on the hot paths

49a32a9

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

bench: B9 also measures serialisation alone, through the model and fr…

fb543de

…om the stored document Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

build(docs): switch from mkdocs-material to zensical

92df625

Move the site config to zensical.toml on the new default theme, swap the docs dependency, and deploy through the GitHub Pages actions since zensical has no gh-deploy. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

jaykv merged commit 7b75204 into v2/bench Oct 13, 2026
13 checks passed

Navigation Menu

Repository navigation

v2: fixes and hardening from review of #6–#8 - #9

v2: fixes and hardening from review of #6–#8#9
jaykv merged 20 commits into
v2/benchfrom
v2/review-fixes

jaykv commented Oct 13, 2026 •

edited

Loading

Uh oh!

sourcery-ai Bot commented Oct 13, 2026

Uh oh!

coderabbitai Bot commented Oct 13, 2026 •

edited

Loading

Review skipped

Uh oh!

sourcery-ai Bot commented Oct 13, 2026

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

jaykv commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bugs fixed (commit 1)

Web hardening (commit 2)

Follow-ups (commit 3)

PATCH and PUT on embedded objects (933df43, ecb42e6)

Third review (7a4012b, 0c5388a)

Writes are validated (1dac7f6)

Documentation and repository (c5eba4d, c23ffbc)

Not changed, with reasons

Verification

Summary by Sourcery

Uh oh!

sourcery-ai Bot commented Oct 13, 2026

Uh oh!

coderabbitai Bot commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

sourcery-ai Bot commented Oct 13, 2026

Reviewer's Guide

Sequence diagram for safe bulk save reconciliation

Sequence diagram for conditional scoped deletion

Sequence diagram for cycle-safe cascading deletes

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jaykv commented Oct 13, 2026 •

edited

Loading

PATCH and PUT on embedded objects (`933df43`, `ecb42e6`)

Third review (`7a4012b`, `0c5388a`)

Writes are validated (`1dac7f6`)

Documentation and repository (`c5eba4d`, `c23ffbc`)

coderabbitai Bot commented Oct 13, 2026 •

edited

Loading