Repository navigation
fix: reset terminal task clocks before resuming execution - #1
Merged
Merged
Conversation
…/intents Reviving a done task through set_goals/add_intent returned it to running but kept the old deadline_at, so workers started with a 1-second clamped run context and every Bash call died with 'tool execution interrupted'. Now admitTaskWhen re-stamps first_run_at/deadline_at (and refreshes the in-process deadline map) when a terminal task with a timeout re-enters running, so revival restarts the budget instead of inheriting an expired one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviving a completed or failed task with an expired deadline kept the previous run's clock, reducing subsequent worker runs to a one-second budget. Terminal tasks now receive a fresh budget when execution starts.
first_run_atanddeadline_atin the same database update that restoresdone,failed, ortimeoutto running.net/http.Validation:
go test ./... -count=1 -timeout 180s,go vet ./...,go mod verify, andgovulncheckpassed locally with Go 1.27.4. CI passed, including task revival race checks, cross-platform launchers, frontend checks, and the embedded binary smoke test.Included in the v1.0.5 changelog with a reference to this PR.