Skip to content

Tear down legacy UI residue and reconcile the gates - #1092

Merged
jayminwest merged 3 commits into
mainfrom
warren/run_2x6kq4myv69d
Aug 27, 2026
Merged

Tear down legacy UI residue and reconcile the gates#1092
jayminwest merged 3 commits into
mainfrom
warren/run_2x6kq4myv69d

Conversation

@warren-run-bot

Copy link
Copy Markdown
Collaborator

Summary

Tear down legacy UI residue (warren-7396)

Run

  • Warren run: run_2x6kq4myv69d
  • Agent: pi
  • Cost: $0.331 (21.0k in / 5.7k out / 1.1M cache-r)

Seeds

  • warren-7396 — Tear down legacy UI residue and reconcile the gates

Commits (2)

  • f2452a6 Tear down legacy UI residue (warren-7396)
  • 7b1a93b Sync seeds and mulch records for pl-7e38 close

Files changed

scripts/bundle-size-budgets.json               |  10 +-
 src/ui/src/components/console/coming-page.tsx  |  26 --
 src/ui/src/components/plan-run-state-badge.tsx |  15 --
 src/ui/src/components/state-badge.tsx          |  11 -
 src/ui/src/components/status-indicator.tsx     |   9 +-
 src/ui/src/components/ui/card.tsx              |  88 -------
 src/ui/src/components/ui/field.tsx             |  92 -------
 src/ui/src/components/ui/page-header.tsx       |  58 -----
 src/ui/src/components/ui/textarea.tsx          |  22 --
 src/ui/src/pages/cost-analytics.tsx            | 345 -------------------------
 10 files changed, 8 insertions(+), 668 deletions(-)

Prompt

Show prompt
Work seeds issue warren-7396 (step 21 — the final step — of plan pl-7e38, the Direction C operator-console UI revamp). First run `sd show warren-7396 --json` and `sd plan show pl-7e38` from the repo root — the plan's context, approach, and acceptance sections are the spec; this prompt is a digest.

Context on main: the entire Direction C console is merged — tokens, shell, all fourteen desktop screens, and the mobile responsive pass. Every page issue was required to delete its legacy counterpart in its own PR, but a long parallel migration leaves residue. This issue is the sweep.

Scope — tear down legacy UI residue and reconcile the gates:
1. Hunt dead code in src/ui: legacy components, hooks, styles, types, and assets no legacy page references anymore. `bunx knip` (via `bun run check:deps`) and grep for orphaned imports/exports are your tools. Delete what nothing reaches. Be careful with components the new pages DO reuse — verify each candidate's importers before deleting.
2. Reconcile plan acceptance criterion 4: no legacy UI pages, components, or styles remain; knip and check:client-contract pass with no new exceptions. Remove any stale entries the migration left in exception/allowlist files (biome.jsonc grandfather lists, file-size budgets for deleted files in scripts/file-size-budgets.json, debt-marker allowlist) — these ratchets only go down, so removing rows for deleted files is correct and required where the guard complains about stale entries.
3. Check docs: if any docs/ path referenced deleted UI surfaces, follow the tombstone rule (docs/README.md pointer entries). docs/ui-revamp/ itself STAYS — it is the design record.
4. Run the full gate suite and fix what the sweep surfaces. If the bundle shrank, run `bun run check:bundle-size --update` — lowering always applies — and commit the diff.
5. Verify acceptance criteria 1, 2, and 4 of the plan hold (routes render Direction C in both themes; IA matches the canvas index; no legacy residue) and say in your close reason which criteria you checked.

Quality gates are terminal: `bun run check:all` must be green before you commit and report done. Known environment quirk: if check:coverage reports "Cannot find module '@sinclair/typebox'" from extensions/judge tests, run `cd extensions/judge && bun install --frozen-lockfile && cd ../..` once and re-run.

Close the issue with `sd close warren-7396 --reason "<what was swept, criteria verified>"`. Also record the plan outcome: `sd plan outcome pl-7e38 --result success` (only if the sweep leaves the gates green). Then commit everything.


🤖 Opened by warren run run_2x6kq4myv69d

Delete the last unreferenced legacy UI files: the cost-analytics page
(folded into Telemetry economics, route already redirected), the
ComingPage placeholder, the StateBadge/PlanRunStateBadge wrappers, and
the unreferenced ui/card, ui/field, ui/page-header, ui/textarea
primitives. Re-baseline the bundle-size budget downward after the
shrink. Final step of plan pl-7e38.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Claude-Session: https://claude.ai/code/session_01CYsdKPF5ZETdCBJAFTu7Hw
@jayminwest
jayminwest enabled auto-merge (squash) August 27, 2026 00:53
@jayminwest
jayminwest merged commit 8105f9f into main Aug 27, 2026
7 checks passed
@jayminwest
jayminwest deleted the warren/run_2x6kq4myv69d branch August 27, 2026 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants