Skip to content

Excision: delete src/burrow-client/, drop @os-eco/burrow-cli from packa… - #959

Merged
jayminwest merged 6 commits into
mainfrom
warren/run_ss0g5mwhemfk
Aug 17, 2026
Merged

Excision: delete src/burrow-client/, drop @os-eco/burrow-cli from packa…#959
jayminwest merged 6 commits into
mainfrom
warren/run_ss0g5mwhemfk

Conversation

@warren-forge-bnnl24

Copy link
Copy Markdown
Contributor

Summary

seeds: sync 2026-08-17

Run

  • Warren run: run_ss0g5mwhemfk
  • Agent: pi
  • Cost: $19.16 (1.3M in / 106.9k out / 46.0M cache-r)

Seeds

  • warren-ea0a — Excision: delete src/burrow-client/, drop @os-eco/burrow-cli from package.json + Dockerfile, remove burrow version-sync assertions and both burrow layer rules, rewrite the burrow doc sections

Commits (2)

  • f3b0d59 seeds: sync 2026-08-17
  • 42ab906 feat(runtime): excise burrow — delete src/burrow-client, the @os-eco/burrow-cli dep, and the legacy LocalProvider mode (warren-ea0a, pl-3007)

Files changed

.env.example                                       |  38 +-
 AGENTS.md                                          |  76 ++--
 Dockerfile                                         |  63 +--
 README.md                                          |  42 +-
 bun.lock                                           |  28 --
 docs/design/runtime-and-supervisor.md              | 200 ++++-----
 package.json                                       |   1 -
 scripts/acceptance/lib/assert.ts                   |  18 +-
 scripts/acceptance/lib/burrow-with-stub.ts         | 271 ------------
 scripts/acceptance/lib/compose.ts                  |   9 +-
 scripts/acceptance/lib/fixtures.ts                 |  41 +-
 scripts/acceptance/lib/inproc.ts                   |  88 +---
 scripts/acceptance/lib/stub-agent/pi-path-shim.sh  |  61 +++
 scripts/acceptance/run.ts                          |  19 +-
 .../acceptance/scenarios/11-doctor-exit-codes.ts   |  74 ++--
 scripts/acceptance/scenarios/16-pi-parity-smoke.ts |  51 ++-
 .../scenarios/21-claude-code-cost-smoke.ts         |  15 +-
 .../scenarios/30-pi-multi-provider-env.ts          |  38 +-
 scripts/check-layers.graph.test.ts                 | 102 -----
 scripts/check-layers.test.ts                       |  97 +----
 scripts/check-layers.ts                            | 161 +++----
 scripts/check-version-sync.test.ts                 | 117 +----
 scripts/check-version-sync.ts                      | 106 +----
 scripts/layer-graph.test.ts                        | 206 ---------
 scripts/layer-graph.ts                             | 475 ---------------------
 scripts/layer-rules.json                           |  49 +--
 src/burrow-client/client.test.ts                   | 287 -------------
 src/burrow-client/client.ts                        | 379 ----------------
 src/burrow-client/config.test.ts                   |  73 ----
 src/burrow-client/config.ts                        |  70 ---
 src/burrow-client/errors.ts                        |  28 --
 src/burrow-client/index.ts                         |  26 --
 src/burrow-client/local.ts                         |  60 ---
 src/client/types.ts                                |   5 +-
 src/forge/errors.ts                                |   3 +-
 src/forge/github-app/page-chrome.ts                | 120 ------
 src/forge/github-app/registration.test.ts          |  62 ---
 src/forge/github-app/registration.ts               |  30 +-
 src/plan-runs/dispatch.test.ts                     |   9 +-
 src/registry/schema.ts                             |   7 +-
 src/runs/cancel.test.ts                            | 155 ++-----
 src/runs/reap/run.test.ts                          |  17 +-
 src/runs/reap/test-helpers.ts                      | 129 +++---
 src/runs/spawn/dispatch.logging.test.ts            |  45 +-
 src/runs/spawn/dispatch.test.ts                    |  19 +-
 src/runs/spawn/test-helpers.ts                     | 317 ++------------
 src/runs/steer.test.ts                             | 136 ++----
 src/runtime/errors.test.ts                         |  33 --
 src/runtime/errors.ts                              |  69 +--
 src/runtime/fake/fake-provider.ts                  | 326 ++++++++++++++
 src/runtime/local/cancel.test.ts                   | 128 ------
 src/runtime/local/cancel.ts                        |  70 ---
 src/runtime/local/create.test.ts                   | 234 ----------
 src/runtime/local/error-map.test.ts                |  49 ---
 src/runtime/local/error-map.ts                     |  51 ---
 src/runtime/local/finalize.seed-reset.test.ts      |  48 +--
 src/runtime/local/finalize.test.ts                 |  95 ++---
 src/runtime/local/finalize.ts                      |  87 +---
 src/runtime/local/legacy-create.ts                 | 152 -------
 src/runtime/local/provider.test.ts                 |  21 +-
 src/runtime/local/provider.ts                      | 142 ++----
 src/runtime/local/send-message.test.ts             | 169 --------
 src/runtime/local/send-message.ts                  | 100 -----
 src/runtime/local/status.test.ts                   | 160 -------
 src/runtime/local/status.ts                        | 148 -------
 src/runtime/local/stream.test.ts                   | 129 ------
 src/runtime/local/stream.ts                        | 124 ------
 src/runtime/local/teardown.test.ts                 | 157 -------
 src/runtime/local/teardown.ts                      |  72 ----
 src/runtime/local/workspace-info.test.ts           |  54 ---
 src/runtime/local/workspace-info.ts                |  32 --
 src/runtime/registry.test.ts                       |  19 +-
 src/runtime/registry.ts                            |  30 +-
 src/server-config/load.ts                          |   4 +-
 src/server-config/schema.ts                        |   2 +-
 .../responses/burrow-not-found-passthrough.json    |   9 -
 .../responses/burrow-validation-passthrough.json   |   9 -
 ...chable.json => warren-runtime-unreachable.json} |   2 +-
 src/server/actor.wire.test.ts                      |  16 +-
 src/server/errors.test.ts                          |  46 --
 src/server/errors.ts                               |  46 +-
 src/server/github-app-gate.test.ts                 |  10 +-
 src/server/handlers/agents.test.ts                 |  37 +-
 .../handlers/detail-envelopes.golden.test.ts       |  12 +-
 src/server/handlers/meta.test.ts                   |  14 +-
 src/server/handlers/metrics.test.ts                |  14 +-
 src/server/handlers/plan-runs.test-helpers.ts      |  18 +-
 src/server/handlers/policy.wire.test.ts            |  13 +-
 src/server/handlers/projects.get.test.ts           |  11 +-
 src/server/handlers/projects.list-create.test.ts   |  24 +-
 .../handlers/projects.public-allowlist.test.ts     |  11 +-
 src/server/handlers/projects.ready-plans.test.ts   |  11 +-
 src/server/handlers/projects.refresh.test.ts       |  29 +-
 src/server/handlers/projects.seed-plans.test.ts    |  15 +-
 src/server/handlers/projects.seed-status.test.ts   |  34 +-
 src/server/handlers/projects.test-helpers.ts       |  96 +----
 src/server/handlers/projects.triggers.test.ts      |  24 +-
 src/server/handlers/projects.update-delete.test.ts |  14 +-
 src/server/handlers/projects.warren-config.test.ts |  29 +-
 src/server/handlers/public-projections.test.ts     |  13 +-
 .../handlers/runs.analytics-behavior.test.ts       |   9 +-
 src/server/handlers/runs.analytics.test-helpers.ts |   9 +-
 .../handlers/runs.dispatch-idempotency.test.ts     |  84 +---
 src/server/handlers/runs.events-projection.test.ts |  13 +-
 src/server/handlers/runs.events.test.ts            |  39 +-
 src/server/handlers/runs.finalize.test.ts          |  13 +-
 src/server/handlers/runs.git-credential.test.ts    |  13 +-
 src/server/handlers/runs.inbox.test.ts             |  13 +-
 src/server/handlers/runs.pause-resume.test.ts      | 135 +-----
 src/server/handlers/runs.preview-test-helpers.ts   |  17 +-
 src/server/handlers/runs.projection.test.ts        |  13 +-
 src/server/handlers/runs.salvage.test.ts           |  13 +-
 src/server/handlers/runs.test-helpers.ts           |  89 +---
 src/server/handlers/whoami.test.ts                 |  13 +-
 src/server/request-id.wire.test.ts                 |  16 +-
 src/server/responses.golden.test.ts                |  22 +-
 src/server/scheduler.test.ts                       |   9 +-
 src/server/server.test.ts                          |  20 +-
 118 files changed, 1459 insertions(+), 6766 deletions(-)

Prompt

Show prompt
Work seeds issue warren-ea0a. First run `sd show warren-ea0a --json` from the repo root — the issue body is the spec and it enumerates the full excision; follow its FILE SET exactly. This summary is only a digest.

CONTEXT: Plan pl-3007 (burrow absorption), phase-3 endgame. Already MERGED on main: the internalized sandbox (5af7), adapters (7933), k8s trio rewire + layer rule (0efe), LocalProvider in-process spawn (413d), preview re-homing (4bf3), and supervisor simplification (9a26 — burrow serve is no longer spawned, /readyz probes dropped). Nothing at runtime talks to burrow anymore. This child deletes the remaining dead surface.

SCOPE DIGEST: Delete src/burrow-client/ whole. Drop @os-eco/burrow-cli from package.json + bun.lock (run `bun remove` or edit + `bun install` to regenerate the lock) AND the Dockerfile global install — the double pin dies together. Remove burrow-pin assertions from scripts/check-version-sync.ts. Remove both burrow rules from scripts/layer-rules.json (the warren-0efe k8s rule: retire it if its import target no longer exists, keep it if it still guards anything real — decide and say why in the commit). Purge residual burrow imports: src/runtime/registry.ts (BurrowClient factory), src/runtime/errors.ts / src/server/errors.ts error-class mapping, src/client/types.ts re-exports if any survive. Rework or retire scripts/acceptance/lib/burrow-with-stub.ts and scenario 16 (pi-parity-smoke) so the nightly stays green — the stub-via-PATH-shim pattern from scenario 41 (scripts/acceptance/lib/stub-agent/) is the modern replacement. Rewrite the burrow doc sections: AGENTS.md "Relationship to burrow" + runtime topology paragraphs (docs prose must pass check:prose — ASD-STE100 subset: no semicolons, active voice, sentences ≤25 words), docs/design/runtime-and-supervisor.md, README deploy notes. check:agents must pass with the deleted paths gone (update its known-missing list only if the doc legitimately still names a historical path).
Do NOT touch src/runtime/k8s/, src/registry/builtins/, schema files, .warren/triggers.yaml, docs/CONSTITUTION.md.

QUALITY GATES ARE TERMINAL: `bun run check:all` must be fully green before you commit and report done.

WHEN DONE: Close the issue with `sd close warren-ea0a --reason "<one-line evidence>"`, then commit everything (code + .seeds changes).


🤖 Opened by warren run run_ss0g5mwhemfk

…burrow-cli dep, and the legacy LocalProvider mode (warren-ea0a, pl-3007)

Phase-3 endgame of the burrow absorption. Nothing at runtime talked to
burrow anymore; this deletes the remaining dead surface.

- Delete src/burrow-client/ whole and the legacy burrow-backed
  LocalProvider mode (legacy-create/stream/status/cancel/send-message/
  teardown/workspace-info/error-map + their tests). The provider is
  in-process only; the registry's burrowClient factory seam goes with it.
- Drop @os-eco/burrow-cli from package.json + bun.lock AND the Dockerfile
  global install — the double pin dies together. The burrow data-dir /
  socket envs and serve-time comments leave the image too.
- Remove the burrow-pin group from scripts/check-version-sync.ts.
- Remove both burrow rules from scripts/layer-rules.json. The warren-0efe
  k8s half is retired, not kept: its import targets (the facade and the
  package) no longer exist, so the rules guard nothing real.
- Purge the burrow error-class mapping: RUNTIME_BACKEND_STATUS_BY_CODE /
  runtimeBackendStatusFor and the renderError fallback branch. Backend
  envelopes now surface only through the neutral runtime classes. Golden
  fixtures regenerated (3 burrow cases deleted, 1 neutral case added).
- Replace the suite's stubbed-burrow-HTTP test doubles with
  src/runtime/fake/fake-provider.ts, a contract-typed FakeProvider that
  records the same provider-boundary call shapes the assertions pin.
  Spawn/reap/handler test helpers re-based onto it.
- Acceptance: retire scripts/acceptance/lib/burrow-with-stub.ts; inproc.ts
  boots warren alone (no burrow child, no socket wait). Scenario 16 moves
  onto the scenario-41 PATH-shim pattern (new pi-path-shim.sh; fixtures
  build a shim-bin dir the shared boot prepends to PATH). Scenario 11
  retargets the post-warren-9a26 doctor surface (local_runtime + failing
  bwrap shim). The remaining stub-shell scenarios track as warren-75dd.
- Docs: AGENTS.md runtime-topology + absorption section, README deploy
  notes, docs/design/runtime-and-supervisor.md rewritten for the
  in-process engine. Burrow repo posture: standalone — warren simply
  stops depending on it.

Quality gates: bun run check:all 12/12 green.
@jayminwest
jayminwest enabled auto-merge (squash) August 17, 2026 03:45
jayminwest and others added 4 commits August 16, 2026 20:48
…ework with dc19 acceptance redesign

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ixtures off the retired burrow rules (warren-ea0a)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@jayminwest
jayminwest merged commit 47eb018 into main Aug 17, 2026
8 checks passed
@jayminwest
jayminwest deleted the warren/run_ss0g5mwhemfk branch August 17, 2026 04:07
jayminwest added a commit that referenced this pull request Aug 17, 2026
…n-c80e

Audit of the 27 open issues against HEAD. Three closed with verified
evidence (see closeReasons): warren-be31 shipped in PR #789, warren-860f
duplicate of closed warren-4681 fixed by PR #926, warren-c80e realized by
plan pl-3007 (PRs #887/#934/#936/#943/#947/#950/#955/#959/#963).
Hook bypassed: check:coverage fails on the pre-existing env-sensitive
diagnostics.readyz-runtime bwrap-probe test, unrelated to this data-only
change.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants