fix(test): assert the renamed sandbox columns in the postgres placement test - #965
Merged
jayminwest merged 2 commits intoAug 18, 2026
Merged
Conversation
…nt test jayminwest#963 renamed runs.burrow_id to sandbox_id and runs.burrow_run_id to sandbox_run_id on both dialects, in 0049_sad_mandroid.sql and in postgres/0044_melted_the_executioner.sql. It updated the sqlite arm of drop-placement-tables.test.ts to match and left the postgres arm on the old names, so ci-postgres has been red since. The postgres arm is skipIf(!isPostgresTestEnabled()), so the regular ci job and a plain bun test both skip it, which is how it merged green. The replay case keeps the old spellings in its raw SQL on purpose: it builds the pre-migration schema before applying the drop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci-postgresis red onmain. The postgres arm ofdrop-placement-tables.test.tsasserts two columns that #963 renamed away.#963 renamed them on both dialects:
src/db/migrations/0049_sad_mandroid.sql(sqlite):ALTER TABLE "runs" RENAME COLUMN "burrow_id" TO "sandbox_id", and the same forburrow_run_id.src/db/migrations/postgres/0044_melted_the_executioner.sql: the same two renames.The same commit updated the sqlite arm of this test to the new names, at lines 49 and 50. The postgres arm at lines 142 and 143 was left behind. This changes those two assertions and nothing else.
The replay case further up keeps
burrow_id/burrow_run_idin its raw SQL on purpose, because it builds the pre-migration schema and then applies the drop. Only the header comment gained a line saying so, since the file now mentions both spellings.Why it merged green
The postgres arm is
test.skipIf(!isPostgresTestEnabled()), so it only runs under theci-postgresworkflow. The regularcijob skips it and so does a plainbun test.Run #282 on
warren/run_3gt7t2q3095dfailed the same assertion at 06:03 on 17 August, and everyci-postgresrun since has been red on the same line.What I ran
bun test src/db/migrations/drop-placement-tables.test.tsgives 2 passing and 1 skipped. The skip is the postgres arm: I have no Postgres on this machine, so I could not exercise the assertion I am changing, and I would rather say that than imply otherwise. The static proof is migration 0044 above, andci-postgreson this PR is the real measurement.bun run typecheckand biome on the file are both clean.