guard: summarize accessibility pending evidence#175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
배경
이 PR은
make evidence-status가 접근성 수동 증거의 pending 여부뿐 아니라 남은 규모도 바로 보여주게 합니다.변경 사항
evidence-status.sh가 접근성 증거가 current pending일 때app-accessibility-evidence-status.sh에서 pending summary를 읽습니다.app_accessibility_manual_pending_scenarios와app_accessibility_manual_pending_fields를 출력합니다.결과
make quality,make guard,pre-commit run --all-files통과.make app-screen-evidence-review,make evidence-status통과.app_accessibility_manual_pending_scenarios=13,app_accessibility_manual_pending_fields=52입니다.리뷰 포인트
evidence-status가 review gate를 대체하지 않고 pending 규모만 보조 출력하는 구조가 적절한지 봐주세요.