guard: report all signing prerequisites#176
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
배경
이 PR은 release signing readiness가 첫 실패에서 멈추지 않고 모든 로컬 전제조건 상태를 한 번에 보여주게 합니다.
변경 사항
release-signing-readiness.sh가 Developer ID identity,notarytool,stapler를 각각present또는missing으로 출력합니다.evidence-status.sh가 새 readiness 실패 문구와*_missing출력도 signing blocker로 분류합니다.결과
make release-signing-readiness는 현재 로컬에서developer_id_identity=missing,notarytool=present,stapler=present를 출력한 뒤 expected fail.make quality,make guard,pre-commit run --all-files통과.make app-screen-evidence-review,make evidence-status통과.리뷰 포인트