__all__ must be a sequence of strings: fix __init__.py and factory.py

[p-vdp]

See the documentation:

The public names defined by a module are determined by checking the module’s namespace for a variable named __all__; if defined, it must be a sequence of strings which are names defined or imported by that module.

pytest ./tests is passing.

[rayrrr]

Thanks @p-vdp for the contribution. However, given that #40 is a long-standing issue, my vote is to remove __all__ completely from both files instead. __all__ is optional to begin with, and only facilitates star imports, which are considered a bad practice.

Background: https://discuss.python.org/t/usage-of-all-in-init-py/17936

OK?

[p-vdp]

I opened this because passing objects through __all__ breaks external tooling that expects strings. If there's a larger refactor planned I understand.

[rayrrr]

@p-vdp we can make a change like this for now and remove it later, but please keep the ([] + [] + [] ...) syntax that was there in the first place to maintain readability. It will still be a a valid sequence.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.61%. Comparing base (eed8089) to head (a43407f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #247   +/-   ##
=======================================
  Coverage   98.61%   98.61%           
=======================================
  Files          20       20           
  Lines         794      794           
=======================================
  Hits          783      783           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.