FIX: Make test_features.FeaturesTest robust (fix #175)#248
Closed
JosefVacha wants to merge 2 commits into
Closed
Conversation
…rmatting differences - Replace string equality checks with JSON object comparison in test_protocol, test_feature_class, and test_geo_interface - This fixes Issue #175 (failing test on Python 3.9.6) by avoiding reliance on specific json.dumps() formatting - Tests now compare parsed JSON objects instead of raw strings Fixes #175.
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix test failures in
test_features.FeaturesTeston Python 3.9.6 (Issue #175).Root Cause
The tests were comparing raw JSON strings (
json.dumps()output) with hardcoded, multi-line strings. Python 3.9+ may have different default formatting forjson.dumps(), causing the string comparison to fail.Proposed Changes
json.loads()objects instead of raw stringsjson.loads()objects instead of raw stringsjson.loads()objects instead of raw stringsVerification
Fixes #175.