Update deface gem to latest version 1.8.1

[liaham]

The latest version is dated with March, 26th 2021.

[marcelbonnet]

deface 1.8.1 seems to work for me:

• Rails 5.2.5
• Ruby 2.7.2
• Redmine 4.2.1

What is this error you mentioned when deface is 1.8.1 and Rails is 5.2 ?

The only error I get is raised by the plugin redmine_maintenance_mode , but it is not causing problems. The error logged is:

Deface: [ERROR] The original source for 'add-maintenance-message-to-bodytop' has changed, this override should be reviewed to ensure it's still valid.

[liaham]

Hi @marcelbonnet ,
Problems occur when viewing revision diffs. There is a discussion in Redmine: https://www.redmine.org/issues/35430.
And this is my comment on the issue: https://www.redmine.org/issues/35430#note-4.

The error message you would get when you enable deface and try to view your revision diffs is something like that:

Rendering repositories/diff.html.erb within layouts/base
Rendered repositories/_related_issues.html.erb (2.5ms)
Rendered common/_tabs.html.erb (0.5ms)
Rendered repositories/_changeset.html.erb (15.1ms)
Rendered common/_diff.html.erb (0.3ms)
Rendered repositories/diff.html.erb within layouts/base (21.1ms)
Completed 500 Internal Server Error in 61ms (ActiveRecord: 16.2ms)

ActionView::Template::Error (undefined method `encoding' for nil:NilClass):

[nanego]

I have updated the current version. This plugin now use Deface 1.6.2.
We cannot use the latest version (1.8) until we have resolved the bug on revisions diff pages.