Conversation
createConnection.ts only skips the dev-only validateEntityMetadata() check when NODE_ENV === 'production', but provider.environment never set NODE_ENV - only STAGE. So every deployed Lambda (including prod) ran that check on every invocation, logging 5 console.error lines per call regardless of whether anything was actually wrong. Seen in prod: renderMerchPrintfiles alone logged this noise ~288 times/day (its 5-minute schedule), which likely dominates any ERROR-level log-volume alerting and buried the one real failure.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
createConnection.tsonly skips the dev-onlyvalidateEntityMetadata()check when
NODE_ENV === 'production', butprovider.environmentnever set
NODE_ENV— onlySTAGE. Every deployed Lambda, includingproduction, ran this check on every invocation.
Fix
Add
NODE_ENV: ${sls:stage}toprovider.environment.Context
renderMerchPrintfilesalone logs this noise ~288 times/day (its5-minute schedule) — 5 ERROR-level lines per call for entities
unrelated to that lambda. This likely dominates any ERROR-level
log-volume alerting and buried the one real failure during the
2026-09-14 incident investigation.
🤖 Generated with Claude Code