Surface SMB tree setup errors as OSError#361
Merged
jborean93 merged 1 commit intoJun 25, 2026
Merged
Conversation
A raw SMBResponseException from SMBRawIO setup did not flow through rmtree's ignore_errors and onerror hooks. The same gap affected remove, rmdir, and scandir for callers using smbclient as a drop-in for os and os.path. The transaction layer already translated these errors for operations wrapped in SMBFileTransaction.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #361 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 24 24
Lines 5288 5291 +3
=======================================
+ Hits 5221 5224 +3
Misses 67 67
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jborean93
approved these changes
Jun 25, 2026
jborean93
left a comment
jborean93
left a comment
Owner
There was a problem hiding this comment.
I'll have to remember to explicit mark this in the changelog as it might catch people who are already ignoring the old exception type but this is still better to align the behaviours between how the transaction APIs work vs the standalone opens. Plus it is also nice that the smbclient stops re-raising smbprotocol defined errors directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A raw SMBResponseException from SMBRawIO setup did not flow through rmtree's ignore_errors and onerror hooks. The same gap affected remove, rmdir, and scandir for callers using smbclient as a drop-in for os and os.path.
The transaction layer already translated these errors for operations wrapped in SMBFileTransaction.