🚀 Release: 1.12.27#645
Merged
Merged
Conversation
Same-named, mechanically-identical Pokemon with different elemental types (e.g. Dialga GX Metal vs Dragon) collapsed into a single CardIdentity. Adds a pokemonType signature column to the identity key, threads types through the TCGdex DTO + parser + resolver, and ships a data migration that splits any mixed-type identity by re-pointing its printings to a typed clone. Joins on cp.tcgdex_id (always populated) rather than the nullable tcgdex_card_id FK so existing data is correctly classified.
Add four cases to TcgdexApiClientTest exercising the new pokemon-types flow: single-type Pokemon parsing, dual-type ordering preservation, empty types for Trainers, and types forwarding through buildDtoFromEntity on local-mirror lookups. Brings the patch coverage on the card-identity PR above the 91.13% Codecov gate.
symfony/polyfill-intl-idn 1.38.0 → 1.38.1 closes CVE-2026-46644 (insecure equivalence on xn-- labels). Pulled along: doctrine/orm 3.6.6 → 3.6.7, phpstan 2.1.55 → 2.1.56, phpunit 13.1.11 → 13.1.12, and sibling Symfony polyfills.
🐛 Fix: include Pokemon type in card identity
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
symfony/polyfill-intl-idn1.38.1 (CVE-2026-46644).