🚀 Release: 1.12.29#649
Merged
Merged
Conversation
CardEnricher::BASIC_ENERGY_IMAGES now points all 9 basic-energy fallbacks at TCGdex sm1/164-172 (the only TCGdex-deployed set with all 9 colors including Fairy). Single CDN, single artwork era — replaces the previous mix of pokemon.com (MEE) and pokemontcg.io (sm1 Fairy) URLs. A two-pass data migration heals already-enriched decks: a narrow URL match for synthetic energy- fallback rows, plus a JOIN-based update for real TCGdex printings tagged with PTCG Live energy-only set codes (MEE/SVE/SME/XYE/BWE) — those carried legacy SVE pokemon.com art or the 404-prone assets.tcgdex.net/en/me/mee/* URLs and now map to sm1 by color. DEFAULT_BASIC_ENERGY_PRINTINGS (minified export / printed labels) is intentionally left unchanged — the MEE 1-8 setCode identifier is user-visible on physical labels and a separate decision.
🐛 fix: homogenize basic-energy images on TCGdex sm1
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sm1/164–172for all 9 colors (single CDN, single artwork era).Version20260528230443that heals every persistedcard_printing.image_urlfor basic energies on nextmake migrations— synthetic-fallback URLs match by exact string, real TCGdex printings under PTCG-Live energy-only set codes (MEE/SVE/SME/XYE/BWE) remap bycard_identity.name→ sm1 URL.docs/changelog.mdfor the full notes.