🐛 fix: don't bump freshness timestamps on position-only reorder#652
Merged
Conversation
Reordering archetypes or deck variants only moves `position`, yet it re-stamped the update timestamps as if the content had changed — polluting the sitemap <lastmod>, the JSON-LD dateModified, the catalog "Updated on" caption and the "sort by updated" order. Add `StructuralChangeTrait` so the `#[ORM\PreUpdate]` hooks on Archetype and Deck leave `updatedAt` / `lastPublishedAt` untouched when `position` is the only changed field. Move `ArchetypeFreshnessListener` collection from postUpdate to preUpdate (where the change-set is reliably exposed) and apply the same guard, so a variant reorder no longer bumps the parent archetype's freshness either.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reordering archetypes (drag-and-drop) or deck variants only changes the
positionfield, but it re-stamped the entities' update timestamps as if the content had changed. That polluted several "content was updated" signals:<lastmod>(viaArchetype.updatedAt/Deck.updatedAt),dateModified,lastPublishedAt).Investigation surfaced three stamping paths off the same reorder, not one:
Archetype::onPreUpdate— bumpedupdatedAtandlastPublishedAt(viaPublishableTimestampsTrait).Deck::onPreUpdate— bumped the deck's ownupdatedAt.ArchetypeFreshnessListener— listened on DoctrinepostUpdateforDeckand re-stamped the parent archetype'slastPublishedAton any variant save, reorder included.Changes
StructuralChangeTrait— single source of truth for display-ordering fields (['position']) plus anisStructuralOnlyChange(PreUpdateEventArgs)helper.Archetype/Deck— their#[ORM\PreUpdate]hooks early-return whenpositionis the only changed field, leaving every timestamp untouched. A change that also touches a real field still bumps as before.ArchetypeFreshnessListener— moved update collection frompostUpdatetopreUpdate(where the change-set is reliably exposed) and applied the same guard.postPersist(new variant = real activity) andpostFlush(bulk writer) are unchanged.features.md(F2.27) andmodels/deck.mdto describe the reorder rule.Test plan
make test— full suite green (newStructuralChangeTest+ extendedArchetypeFreshnessListenerTest)updated_at/last_published_atstay put whilepositionmovesupdated_atnor the archetype'slast_published_atchange