Fix option set some with reference #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
==========================================
+ Coverage 92.09% 92.25% +0.15%
==========================================
Files 22 22
Lines 1265 1265
Branches 1265 1265
==========================================
+ Hits 1165 1167 +2
+ Misses 48 47 -1
+ Partials 52 51 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
previously, option_set_some would erroneously strip references within the option, so for `#[field(set, option_set_some)] field: Option<&'a str>`, we would generate `set_field(&mut self, field: str) -> &mut Self`, but now we correctly generate `set_field(&mut self, field: &'a str) -> &mut Self`
jbr
force-pushed
the
fix-option-set-some-with-reference
branch
from
f0ef37f to
a29838e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.