Fix namespacing in login server module to support nested usage - #11
Open
NorbertHandraAGES wants to merge 1 commit into
Open
Fix namespacing in login server module to support nested usage#11NorbertHandraAGES wants to merge 1 commit into
NorbertHandraAGES wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the login server module does not work correctly when nested inside other modules.
The UI uses proper namespacing, but the server relied on
NS(id, ...), which does not correctly handle nested module contexts. This caused a mismatch between UI inputs and server logic.This PR replaces
NS(id, ...)withsession$ns(...)withinlogin_server, ensuring consistent namespacing and correct behavior in nested modules.This addresses issue #9.
Thanks for providing this useful package!