Add --ignore-duplicate flag to avoid build failures on repeated CI builds#115
Open
bbourdrez wants to merge 1 commit into
Open
Add --ignore-duplicate flag to avoid build failures on repeated CI builds#115bbourdrez wants to merge 1 commit into
bbourdrez wants to merge 1 commit into
Conversation
|
The official argument is --skip-duplicate, so I would be inclined to rename --ignore-duplicate to match; |
Contributor
|
@jcansdale @bbourdrez any way we can move this one forward? I've found myself needing this a few times now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When doing builds from github actions or other CI/CD systems it's often good to not fail on repeated production builds of the same package, so this new flag allows you to tell gpr to succeed when pushing a duplicate version (other than showing the server-provided error in the output).
There doesn't seem to be any mocking set up for the network-related parts of the code, so there's no tests.