Remove readline from lua#80
Conversation
|
I think readline is only used for the lua command-line interpreter, right? |
|
@sagebind That's my understanding, yeah. I went through the C source to confirm and believe that to be correct. |
The cernan use-case for lua is one that does not use readline. On systems that attempt to statically linked cernan against MUSL libc the readline dependency breaks the build on account of the difficulty of building readline in that environment. I could not determine if there were a cleaner way to disable readline other than but permanently. That is, maybe this approach is a hack. I _think_ disabling readline is okay here as the focus of the library appears to be the use of lua in a purely embedded environment. Signed-off-by: Brian L. Troutwine <blt@postmates.com>
|
Readline also gives me a headache using this library with https://github.com/japaric/trust, I would appreciate if this would be merged! |
|
@SirVer I forked this library to https://github.com/blt/mond which removes the readline issue per this PR, updates the codebase some based on clippy suggestions. I aim to do more work in support of https://github.com/postmates/cernan. Perhaps mond will work for you? It's on crates if you want to give it a try. |
|
Unfortunately, mond still contains the problem I describe in #91, so it is only a partial fix for me. I maintain my own fork (but retaining the fork history) with the changes I needed to make to support the architectures I care about. I have been watching your talk about cernan and am very intrigued by it. I hope I get a chance to test it out at work. |
@SirVer I'd be happy to incorporate your work into mond.
Thanks! Let us know if you run into any issues and we'll work them. |
3 participants
The cernan use-case for lua is one that does not use readline. On
systems that attempt to statically linked cernan against MUSL libc the
readline dependency breaks the build on account of the difficulty of
building readline in that environment. I could not determine if there
were a cleaner way to disable readline other than but permanently.
That is, maybe this approach is a hack.
I think disabling readline is okay here as the focus of the library
appears to be the use of lua in a purely embedded environment.
Signed-off-by: Brian L. Troutwine blt@postmates.com