Skip to content

fix: add defence for Command Injection Attack #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DuLinRain wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: add defence for Command Injection Attack #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4330a4
fix: add defence to Command Injection Attack
DuLinRain Jan 26, 2021
34cfefe
feat: add test case for Command Injection Attack
DuLinRain Jan 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ var curl = function(url, options, callback) {
var opts = new optionsBuilder();
options = opts.follow_redirects().silent().max_redirs(5).connect_timeout(5);
}

if (/[`$&{}[;|]/g.test(url)) {
return callback(new Error('Invalid Url'), null, null);
}

var curlString = 'curl "' + url + '" ';

Expand Down
7 changes: 6 additions & 1 deletion tests/testCurl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,9 @@ curl("www.google.com", opts, function(err, resp) {
})

opts.follow_redirects(false);
assert.equal(opts.stringify().trim(), "-v -S -k --proxy-ntlm -ntlm --connect-timeout 3 --max-redirs 10");
assert.equal(opts.stringify().trim(), "-v -S -k --proxy-ntlm -ntlm --connect-timeout 3 --max-redirs 10");

curl("www.google.com' & touch test.txt #'", function(err, resp) {
assert.notEqual(err, null, "there should be errors from curling with unsafe url");
assert.equal(resp, null, "curling with unsafe url should return error");
});