Skip to content

Removed 8 unnecessary stubbings in CommunicationtTestMocker#4

Open
ARUS2023 wants to merge 1 commit intojd-opensource:masterfrom
ARUS2023:remove-unnecessary-stubbings
Open

Removed 8 unnecessary stubbings in CommunicationtTestMocker#4
ARUS2023 wants to merge 1 commit intojd-opensource:masterfrom
ARUS2023:remove-unnecessary-stubbings

Conversation

@ARUS2023
Copy link
Copy Markdown

@ARUS2023 ARUS2023 commented Oct 6, 2023

In our analysis of the project, we observed that the

  1. CommunicationtTestMocker.mockTopology contains 1 stubbing which is created but never executed.
  2. CommunicationtTestMocker.mockConfiguration contains 6 stubbings which are created but never executed.
  3. CommunicationtTestMocker.mockTopologyWithTCP contains 1 stubbing (stubbed CurrentViewMembermethod) which is created but never executed in 2 tests: ServerCommunicationLayerTest.testDoubleNettyNodes and ServerCommunicationLayerTest.testNettyNodesNetwork

Unnecessary stubbings are stubbed method calls that were never realized during test execution. Mockito recommends to remove unnecessary stubbings (https://www.javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/exceptions/misusing/UnnecessaryStubbingException.html).

We propose below a solution to remove the unnecessary stubbing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant