Fix/tc_bjd reporting - #307
Open
melodyxtang wants to merge 2 commits into
Open
melodyxtang wants to merge 2 commits into
melodyxtang wants to merge 2 commits into
Conversation
Adds tc_bjd/tp_bjd converting the reported conjunction/periastron times back to the observed frame (the Mahajan 2024 frame bug). Verified on GJ 1214: tc_bjd lands 0.6sigma from the paper. Model path unchanged.
# Conflicts: # tests/test_transit_ltt.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds observed-frame
tc_bjd/tp_bjdso reported conjunction/periastron times are inBJD_TDB, not the target frame. Verified on GJ 1214:tc_bjdlands ~0.5σ from the paper.