Skip to content

fix(ci): preserve active Claude reviews on unrelated labels - #3

Open
jdueadev wants to merge 1 commit into
mainfrom
ci/review-trigger-permissions
Open

jdueadev wants to merge 1 commit into
mainfrom
ci/review-trigger-permissions

Conversation

@jdueadev

@jdueadev jdueadev commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

Unrelated label events currently cancel an active Claude review even though their replacement job is skipped. Give those events a separate concurrency group and remove the unused issues: write grant. Verified both group paths and preservation of PR comment and OIDC permissions; existing review triggers remain unchanged.

Summary by CodeRabbit

  • Chores
    • Updated automated review workflow handling so label-related events are grouped separately from other review runs.
    • Adjusted the workflow’s permissions.

Copilot AI balanced review requested due to automatic review settings November 13, 2026 05:17
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Claude review workflow now uses separate concurrency groups for claude-review label events and other label events. The review job no longer requests issues: write.

Changes: Workflow adjustments

Layer / File(s) Summary
Concurrency and permissions
.github/workflows/claude-review.yml
The concurrency group uses review or ignored alongside the PR number. The job no longer requests issues: write.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Low

Possibly related PRs

Merge Risk: Minimal · up to fdd98

This workflow-only change keeps an active Claude review from being cancelled by unrelated label events and trims token permissions. No merge-blocking risk was found.

Architecture risk: Low · up to fdd98

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/claude-review.yml: The concurrency group now separates non-claude-review label events from review events using ignored and review suffixes, respectively; both groups remain keyed by PR number.
  • observed — Modified behavior in .github/workflows/claude-review.yml: Removed the job’s issues: write permission.
Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the main change: the workflow's concurrency handling is changed so unrelated label events no longer cancel an active Claude review. The raw summary confirms the concurrency group split…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: the workflow's concurrency handling is changed so unrelated label events no longer cancel an active Claude review. The raw summary confirms the concurrency group split for non-claude-review label events and the removal of issues: write. The title uses the conventional fix(ci) prefix and is specific enough for a teammate scanning history.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 93dc2fc and fdd9872.

Files selected for processing: 1

  • .github/workflows/claude-review.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues for the workflow change that isolates unrelated label events.

No open issues 🎉

What changed in this PR

This PR prevents unrelated label events from canceling active Claude reviews in the repository’s review workflow.

Changes:

  • Separates unrelated label events into an ignored concurrency group while retaining existing review triggers.
  • Removes the unused issues: write permission, preserving pull-request comment and OIDC permissions.
File Description
.github/​workflows/​claude-review.yml Isolates unrelated label events and removes an unused permission.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants