Repository navigation
fix: restore Kaggle worker and repair failing fast tests on main - #229
Merged
Merged
Conversation
- Restore scripts/kaggle_worker_entry.py and scripts/kaggle_runtime_env.py. 6d9fe7f removed them as obsolete, but the Kaggle/Colab launchers (kaggle_runner, kernel_package, remote_package, colab_runner) still package and run them, and benchmark_jax_rl imports kaggle_runtime_env. - rollout-phase-profile: SystemExit() takes no `file=` kwarg, so a missing integration worktree crashed with TypeError instead of a clean message. - Kaggle submission packager: add factored_decode_scan, map_pool/load and map_pool/bake to RUNTIME_FILES; packaged modules import them, so the submission would fail with ModuleNotFoundError. - Tests: src.training.curriculum moved to src.opponents.curriculum; bounds_exit_time test used a 1-unit board (BOARD_SIZE is 100); preflight sweep reseed_every_updates was deliberately raised to 100. - Docs: drop links to files removed at retirement and to uncommitted outputs/, and reword AGENTS.md so it no longer names removed doc dirs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jdueadev
force-pushed
the
fix/main-test-failures
branch
from
November 13, 2026 00:09
a97e4ea to
f628885
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the 19
make test-fastfailures onmain(surfaced by the new Tests workflow in #228).Real bugs
scripts/kaggle_worker_entry.pyandscripts/kaggle_runtime_env.pyas obsolete, butkaggle_runner,kernel_package,remote_packageandcolab_runnerstill package and run them, so every Kaggle launch would fail during bootstrap. Restored from 6d9fe7f~1.rollout-phase-profilecrash.SystemExit(msg, file=sys.stderr)raises TypeError. It now exits with the message, and a test covers this.factored_decode_scan,map_pool/loadandmap_pool/bakeare imported by packaged modules but weren't inRUNTIME_FILES.Stale tests and docs
src.training.curriculum→src.opponents.curriculum(moved in d00030e).bounds_exit_timetest assumed a 1-unit board.BOARD_SIZEis 100, so the test now starts at the right edge.reseed_every_updateswas intentionally changed to 100 in 9c8af31.outputs/are fixed.Testing
Locally (Windows), the targeted files pass. The full fast suite shows 1335 passed and 9 failed, and all 9 are Windows-only (path separators,
.netrc, Cursor hooks) and not in the Linux CI failure list. CI on this PR is the authoritative check.🤖 Generated with Claude Code