Skip to content

fix(ci): preserve active Claude reviews on unrelated labels - #231

Merged
jdueadev merged 1 commit into
mainfrom
ci/review-trigger-permissions
Nov 13, 2026
Merged

jdueadev merged 1 commit into
mainfrom
ci/review-trigger-permissions

Conversation

@jdueadev

@jdueadev jdueadev commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

Unrelated label events currently cancel an active Claude review even though their replacement job is skipped. Give those events a separate concurrency group and remove the unused issues: write grant. Verified both group paths and preservation of PR comment and OIDC permissions; existing review triggers remain unchanged.

Summary by CodeRabbit

  • Chores
    • Updated review automation so unrelated label events no longer share the review workflow’s cancellation scope.
    • Reduced the permissions available to the workflow. These changes do not affect app features or the user experience.

Copilot AI balanced review requested due to automatic review settings November 13, 2026 05:17
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The review workflow assigns label events unrelated to claude-review to a separate concurrency group. It also removes the job’s issues: write permission.

Changes: Review workflow adjustments

Layer / File(s) Summary
Concurrency and permissions
.github/workflows/claude-review.yml
Unrelated label events use an ignored concurrency group instead of the review group. The job’s issues: write permission is removed.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: Minimal · up to e6097

This CI workflow change keeps an active Claude review from being cancelled by unrelated label events and trims token permissions. No concrete merge-blocking risk was found.

Architecture risk: Low · up to e6097

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/claude-review.yml: The concurrency group now uses an ignored suffix for labeled events whose label is not claude-review; other events use review. This separates unrelated label events from review runs for concurrency cancellation.
  • observed — Modified behavior in .github/workflows/claude-review.yml: The job’s issues: write permission was removed.
Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the main change: unrelated label events now use a separate concurrency group so they do not cancel an active Claude review. The change set matches this, since the workflow moves ignore…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: unrelated label events now use a separate concurrency group so they do not cancel an active Claude review. The change set matches this, since the workflow moves ignored label events to an ignored group and removes issues: write. The title does not mention the permission removal, but that is a secondary change.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 1b6e5e4 and e6097da.

Files selected for processing: 1

  • .github/workflows/claude-review.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the workflow change that isolates unrelated label events and removes an unused permission.

No open issues 🎉

What changed in this PR

This PR prevents unrelated label events from canceling active Claude reviews in the GitHub Actions workflow.

Changes:

  • Separates unrelated label events into an ignored concurrency group while keeping existing review triggers unchanged.
  • Removes the unused issues: write permission while preserving pull request comment and OIDC permissions.
File Description
.github/​workflows/​claude-review.yml Isolates unrelated label events and removes an unused permission.

Review effort: Balanced

@jdueadev
jdueadev merged commit 3afdcb1 into main Nov 13, 2026
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants