This repository was archived by the owner on Jan 8, 2025. It is now read-only.
respect proxy environment variables for S3 access#160
Open
thierrylamarre wants to merge 1 commit into
Open
Conversation
thierrylamarre
force-pushed
the
s3_proxy_envvars
branch
3 times, most recently
from
February 21, 2020 20:11
fdcf2ba to
2901b68
Compare
thierrylamarre
force-pushed
the
s3_proxy_envvars
branch
from
February 21, 2020 20:31
2901b68 to
c8f6fbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The s3 client does not seem to respect http proxy environment variables by default.
This adds support for respecting them with a small caveat: it does not add support for the
NO_PROXY/no_proxyenvironment variables.