Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/comment-release-fixes.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: comment release fixes
on:
{
release: { types: [published] },
workflow_dispatch:
{
inputs:
{
tag: { required: true, type: string },
dry_run: { required: false, type: boolean, default: true },
},
},
}
jobs:
comment:
permissions:
{ contents: read, pull-requests: read, issues: write, discussions: write }
uses: jdx/workflows/.github/workflows/comment-release-fixes.yml@4c952564543dd54d60f15ef4062af7fb60c5561d
with:
{
tag: "${{ inputs.tag || github.event.release.tag_name }}",
marker_prefix: usage-fixed-in,
dry_run: "${{ inputs.dry_run || false }}",
}
4 changes: 2 additions & 2 deletions .github/workflows/perf-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ jobs:
cp /tmp/shadow-report.md /tmp/tak-out/shadow.md 2>/dev/null || true
printf '%s %s\n' "${HEAD_SHA:0:12}" "${BASE_SHA:0:12}" > /tmp/tak-out/shas

- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
if: always()
with:
name: tak-report
Expand Down Expand Up @@ -259,7 +259,7 @@ jobs:
checks: write # attach the regression gate to the measured PR head SHA
pull-requests: write # the sticky comment, and nothing else
steps:
- uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
- uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
with:
name: tak-report
path: /tmp/tak-out
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/perf.yml
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ jobs:
git notes --ref=tak show HEAD > /tmp/tak-out/note
git rev-parse HEAD > /tmp/tak-out/sha

- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
if: github.ref == 'refs/heads/main'
with:
name: tak-measurement
Expand All @@ -118,7 +118,7 @@ jobs:
permissions:
contents: write
steps:
- uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8
- uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
with:
name: tak-measurement
path: /tmp/tak-out
Expand Down
13 changes: 13 additions & 0 deletions .github/workflows/publish-cli.yml
Original file line number Diff line number Diff line change
Expand Up @@ -370,3 +370,16 @@ jobs:
# with:
# token: ${{ secrets.GH_BOT_TOKEN }}
# formula: usage

comment-release-fixes:
needs: release
if: ${{ !cancelled() && needs.release.result == 'success' && startsWith(github.ref, 'refs/tags/v') }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Draft runs enter notification work

A manual publish-cli run on a v* tag skips publication, but the successful release job still lets comment-release-fixes run without a dry_run input. If the shared workflow does not block draft releases, this can send comments before the release is public. Exclude workflow_dispatch here, or require an output from the publication step.

Suggested change
if: ${{ !cancelled() && needs.release.result == 'success' && startsWith(github.ref, 'refs/tags/v') }}
if: ${{ !cancelled() && github.event_name != 'workflow_dispatch' && needs.release.result == 'success' && startsWith(github.ref, 'refs/tags/v') }}

Fix in Claude Code

permissions:
contents: read
pull-requests: read
issues: write
discussions: write
uses: jdx/workflows/.github/workflows/comment-release-fixes.yml@4c952564543dd54d60f15ef4062af7fb60c5561d
with:
tag: ${{ github.ref_name }}
marker_prefix: usage-fixed-in
Loading