Repository navigation
fix(retry): enforce timeout_minutes without coreutils timeout - #18
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 16 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5441d46. Configure here.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

retryenforcedtimeout_minutesonly whentimeoutorgtimeoutwas on the PATH, and otherwise warned and ran with no limit. Hosted macOS runners don't ship either, so a hung attempt there would run until the job's own timeout instead of being retried.When neither binary exists, the action now runs the attempt in the background with a small watchdog that sends TERM, then KILL 30 seconds later, and the attempt fails with that exit status.
timeout_minutes: 0still means no limit.Tested locally with
PATH=/usr/bin:/bin(notimeouton macOS): asleep 20attempt is killed at the limit and retried, and a command that fails once then succeeds still passes on the second attempt.AI-assisted — Tool: Claude Code; model: anthropic/claude-sonnet-5-5; version: unavailable.
🤖 Generated with Claude Code
Note
Medium Risk
Changes process-group signaling and kill timing for all attempts on runners without coreutils timeout; behavior on Linux with
timeoutis unchanged but the fallback path is new shell logic worth validating on macOS CI.Overview
Fixes
timeout_minuteson hosted macOS runners where neithertimeoutnorgtimeoutis available. Previously the action logged a warning and ran attempts with no per-attempt limit, so hung commands only stopped at the job timeout and never triggered retries.The timeout logic is refactored into
run_limited: it still prefers coreutilstimeout/gtimeout, but when those are missing it backgrounds the attempt under job control and uses a watchdog that sends TERM to the process group, then KILL after 30 seconds (mirroring--kill-after=30).timeout_minutes: 0still disables limiting. Header comments are updated to document the watchdog fallback.Reviewed by Cursor Bugbot for commit 6a3ad2f. Bugbot is set up for automated code reviews on this repo. Configure here.