Skip to content

feat(lib): implement double-chunked ray-triangle tests for better perf.#446

Open
jeertmans wants to merge 16 commits into
mainfrom
double-chunk
Open

feat(lib): implement double-chunked ray-triangle tests for better perf.#446
jeertmans wants to merge 16 commits into
mainfrom
double-chunk

Conversation

@jeertmans
Copy link
Copy Markdown
Owner

No description provided.

@github-actions github-actions Bot added the python Changes Python code label May 13, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

❌ Patch coverage is 91.52542% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.28%. Comparing base (e36e821) to head (b11851a).

Files with missing lines Patch % Lines
differt/src/differt/rt/_utils.py 91.52% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
- Coverage   86.41%   86.28%   -0.13%     
==========================================
  Files          32       32              
  Lines        3165     3245      +80     
==========================================
+ Hits         2735     2800      +65     
- Misses        430      445      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This comment was marked as resolved.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 13, 2026

Merging this PR will degrade performance by 14.89%

⚡ 2 improved benchmarks
❌ 7 regressed benchmarks
✅ 6 untouched benchmarks
⏩ 7 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
test_compute_paths[medium-disconnect-hybrid] 30.9 s 56.3 s -45.14%
test_compute_paths[medium-no_disconnect-exhaustive] 20.1 s 22.9 s -12.24%
test_compute_paths[small-disconnect-hybrid] 137.7 ms 176.4 ms -21.92%
test_first_triangles_hit_by_rays[medium] 11.2 s 14.5 s -22.83%
test_first_triangles_hit_by_rays[small] 43 ms 30.7 ms +40.25%
test_rays_intersect_any_triangle[medium] 8.5 s 10.3 s -17.4%
test_rays_intersect_any_triangle[small] 29 ms 15.8 ms +83.64%
test_transmitter_visibility[medium] 7 s 14.6 s -51.66%
test_transmitter_visibility[small] 32.1 ms 40.9 ms -21.43%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing double-chunk (b11851a) with main (e36e821)

Open in CodSpeed

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions github-actions Bot added the tests Changes tests label May 13, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Comment thread differt/src/differt/rt/_utils.py Outdated
Comment thread differt/src/differt/rt/_utils.py Outdated
Comment thread differt/src/differt/rt/_utils.py Outdated

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Changes Python code tests Changes tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants