docs(plans): granular Phase 5 + Phase 6 sub-plans#107
Conversation
WalkthroughThis PR adds two new implementation plan documents (Phase 5 and Phase 6) and updates the main progress tracker. Phase 5 outlines a handler registry refactoring for text extraction with expanded file-type support (CSV, XLSX, JSON) and a gated HTML handler, plus a safe ZIP processing path with archive-level and per-entry failure semantics. Phase 6 describes the dashboard-side implementation for resumable uploads with a configurable file-size threshold, real progress polling, state transitions, supported-file updates, and improved error handling. The progress tracker is updated to reference both phase-specific plans. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsStopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/plans/2026-06-10-phase6-dashboard-upload-ux-impl.md`:
- Line 19: dashboard/components/upload-zone.tsx is dead (unused) — either remove
it or integrate it into the active upload flow: if it's obsolete, delete
dashboard/components/upload-zone.tsx and remove any stale docs references in
docs/plans; if it was meant to be used, import and wire the component into
dashboard/app/upload/page.tsx and ensure client API calls match
dashboard/lib/api.ts signatures (adjust props or API call names to match
existing functions). Also run a repo-wide search for "upload-zone" to confirm no
other references remain and update any docs that mention the component.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 9b6e19fc-5c71-49e7-a658-a9615ebddc93
📒 Files selected for processing (3)
docs/plans/2026-05-31-large-upload-gcs-resumable-plan.mddocs/plans/2026-06-10-phase5-handler-registry-zip-impl.mddocs/plans/2026-06-10-phase6-dashboard-upload-ux-impl.md
1 participant
What
Granular, code-grounded sub-plans for the next two phases of the large-upload feature, mirroring the Phase 4 sub-plan format. Docs only.
docs/plans/2026-06-10-phase5-handler-registry-zip-impl.md— handler registry + Tier-1 widening (csv/xlsx/json/html) + safe streaming ZIP (T5.1–T5.3), with resolved decisions (partialpolicy,unzipper.Open.buffer()) and STOP GATE 5a (HTML dep).docs/plans/2026-06-10-phase6-dashboard-upload-ux-impl.md— dashboard resumable client + real progress + honest accept-list + error mapping (T6.1–T6.2), grounded in the actualpage.tsx/lib/api.ts(incl. the[object Object]root cause atpage.tsx:119and the deadupload-zone.tsx).docs/plans/2026-05-31-large-upload-gcs-resumable-plan.md— tracker now links both sub-plans.Why
Phase 4 is merged + live in prod. These tee up Phases 5 (server ZIP) and 6 (dashboard UX) so they can be executed test-first without re-planning. No code changes;
pnpm verify:fast(incl. markdownlint, docs-check, security) is green.