Skip to content

angular2-masonry won't compile under Angular 5 #61

Description

@web-snake

Angular 5 has stricter Typescript compilation configurations and will not compile:
node_modules/angular2-masonry/index.ts
The error is:
ERROR in ./node_modules/angular2-masonry/index.ts
Module build failed: Error: myapp/node_modules/angular2-masonry/index.ts is not part of the compilation output. Please check the other error messages for details.

This type script file is incorrectly packed in angular2-masonry according to the Angular team.
You should not package uncompiled .ts files in packages because it can compile diffferently under different configs.
Angular plans to make it even harder for you to use this bad practice in the future. YOur package is already broken for Angular 5.
Here's an Angular team member saying this: angular/angular-cli#8284
( see filipesilva 's comment )

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions