Fix SIC extraction for cell types with shared prefixes#6
Merged
Conversation
The coefficient name matching used a substring search that incorrectly matched multiple cell types when one name was a prefix of another (e.g., cd4tcells also matched cd4tcells_ICOS, cd4tcells_PD1, etc.). Changed grep pattern to use regex $ anchor to match only coefficient names ending with the exact source type name. Fixes #5
CRAN removes old macOS ARM binaries when new versions are released, causing cached lockfiles to reference non-existent packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
mul.tensor: i incompatible to jerror when extracting SICs from datasets where one cell type name is a prefix of another (e.g.,cd4tcells,cd4tcells_ICOS,cd4tcells_PD1).$anchor.extract_group_sics(),.extract_patient_sics(),.extract_image_sics()Fixes #5