This repository was archived by the owner on Apr 24, 2025. It is now read-only.
Add new command of 'add github labels to REPO' to bot (WIP)#72
Closed
halkeye wants to merge 1 commit intojenkins-infra:masterfrom
Closed
Add new command of 'add github labels to REPO' to bot (WIP)#72halkeye wants to merge 1 commit intojenkins-infra:masterfrom
halkeye wants to merge 1 commit intojenkins-infra:masterfrom
Conversation
Member
Author
|
also need @bitwiseman's help to add support for updating labels, but waiting to hear back about the desired builder pattern for it. |
Member
Author
|
YAY! updating labels - hub4j/github-api#649 |
Member
Author
|
IDEA: change this to rebase repo, and make sure we have github topics of "jenkins" and "jenkins-plugin" setup |
Contributor
|
@halkeye |
bitwiseman
reviewed
Apr 1, 2020
pom.xml
Outdated
| <groupId>org.kohsuke</groupId> | ||
| <artifactId>github-api</artifactId> | ||
| <version>1.89</version> | ||
| <version>1.101</version> |
Contributor
There was a problem hiding this comment.
Suggested change
| <version>1.101</version> | |
| <version>1.109</version> |
bitwiseman
reviewed
Apr 1, 2020
Comment on lines
+866
to
+964
| /* | ||
| * when updateLabel is published | ||
| * repo.updateLabel( | ||
| * Strings.isNullOrEmpty(label.oldname) ? label.name : label.oldname, | ||
| * label.name, // newname | ||
| * label.color, | ||
| * label.description | ||
| * ) | ||
| */ |
Contributor
There was a problem hiding this comment.
From hub4j/github-api#724 :
Suggested change
| /* | |
| * when updateLabel is published | |
| * repo.updateLabel( | |
| * Strings.isNullOrEmpty(label.oldname) ? label.name : label.oldname, | |
| * label.name, // newname | |
| * label.color, | |
| * label.description | |
| * ) | |
| */ | |
| ghLabels.get(Strings.isNullOrEmpty(label.oldname) ? label.name : label.oldname) | |
| .update() | |
| .name(label.name) // newname | |
| .color(label.color) | |
| .description(label.description) | |
| .done(); |
halkeye
force-pushed
the
add-github-labels
branch
from
ce5bc4c to
de3c910
Compare
Contributor
|
Is this still a WIP? |
Member
Author
|
Yea I rebased it but it needs a permanent location for the yaml and tests |
timja
reviewed
Oct 17, 2020
| private static final RepoLabels labelsYAML; | ||
| static { | ||
| try { | ||
| URL url = new URL("https://raw.githubusercontent.com/jenkinsci/.github/4f59a6219705df14067688df4f2a503e143cfa92/labels.yaml"); |
Member
Author
There was a problem hiding this comment.
master doesn't have the file so it would 404, but yea the plan would be master
Contributor
|
Would be nice to get it over the line to avoid further merge conflicts |
Member
Author
|
https://plugins-self-service-3ir4b.ondigitalocean.app/ is way easier |
Contributor
|
Looks nice though the UI does not seem to work for me (blank screen, maybe
long initial data loading).
Time to start a thread in the infra mailing list?
…On Tue, Jun 1, 2021 at 7:18 AM Gavin Mogan ***@***.***> wrote:
Closed #72 <#72>.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#72 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAW4RID4BFU6BTZMYTPHMVTTQRUT5ANCNFSM4J5U3YAQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP to support jenkinsci/.github#27