[JENKINS-75144] Add async processing for webhook events in Organizati…#540
Draft
sinedd777 wants to merge 1 commit intojenkinsci:masterfrom
Draft
[JENKINS-75144] Add async processing for webhook events in Organizati…#540sinedd777 wants to merge 1 commit intojenkinsci:masterfrom
sinedd777 wants to merge 1 commit intojenkinsci:masterfrom
Conversation
…onFolder Fixes the issue where one unauthenticated OrganizationFolder hitting GitHub API rate limits would block webhook processing for all other OrganizationFolders. Changes: - Created OrganizationFolderAsyncHelper to handle conditional async processing - Modified onSCMHeadEvent, onSCMNavigatorEvent, and onSCMSourceEvent to use async processing when multiple folders exist - Uses CompletableFuture with timeout to prevent indefinite blocking - Maintains synchronous behavior for single folder scenarios (for compatibility) The fix ensures that authenticated folders can continue processing webhooks even when unauthenticated folders are rate-limited by GitHub's 60 requests/hour limit for anonymous access.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…onFolder
Fixes the issue where one unauthenticated OrganizationFolder hitting GitHub API rate limits would block
webhook processing for all other OrganizationFolders.
Changes
OrganizationFolderAsyncHelperto handle conditional async processingonSCMHeadEvent,onSCMNavigatorEvent, andonSCMSourceEventto use async processing whenmultiple folders exist
CompletableFuturewith timeout to prevent indefinite blockingThe fix ensures that authenticated folders can continue processing webhooks even when unauthenticated
folders are rate-limited by GitHub's 60 requests/hour limit for anonymous access.
Testing done
some without)
Submitter checklist
branch!
JENKINS-75144